Merge pull request #59 from chrisradek/fix-spurious-recorders

fix(core): prevents CentralizedSamplingStrategy from instatiating extraneous recorders when no origin set
aws · Feb 5, 2019 · f227f20 · f227f20
2 parents eed8aa9 + 2d06f8a
commit f227f20
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/...-core/src/main/java/com/amazonaws/xray/strategy/sampling/CentralizedSamplingStrategy.java b/...-core/src/main/java/com/amazonaws/xray/strategy/sampling/CentralizedSamplingStrategy.java
@@ -60,10 +60,6 @@ public SamplingResponse shouldTrace(SamplingRequest samplingRequest) {
             logger.debug("Determining shouldTrace decision for:\n\tserviceName: " + samplingRequest.getService().orElse("") + "\n\thost: " + samplingRequest.getHost().orElse("") + "\n\tpath: " + samplingRequest.getUrl().orElse("") + "\n\tmethod: " + samplingRequest.getMethod().orElse("") + "\n\tserviceType: " + samplingRequest.getServiceType().orElse(""));
         }
 
-        if (!samplingRequest.getServiceType().isPresent()) {
-            samplingRequest.setServiceType(AWSXRayRecorderBuilder.defaultRecorder().getOrigin());
-        }
-
         if (manifest.isExpired(Instant.now())) {
             logger.debug("Centralized sampling data expired. Using fallback sampling strategy.");
             return fallback.shouldTrace(samplingRequest);