AWSTools.Powershell\tools\chocolateyInstall.ps1 uses deprecated commands

[ghost]

Describe the bug

Unable to install AWSPowershell due to C:\ProgramData\chocolatey\lib\AWSTools.Powershell\tools\chocolateyInstall.ps1 trying to call deprecated commands (Write-ChocolateySuccess)

Expected Behavior

Running the following command results in a successful installation of AWsPowershell without any errors:

Install-Module -Name AWSPowerShell -Force

Current Behavior

Running Install-Module -Name AWSPowerShell -Force results in the following error:

ERROR: The term 'Write-ChocolateyFailure' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

The install of awstools.powershell was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\AWSTools.Powershell\tools\chocolateyInstall.ps1'.
 See log for details.

Chocolatey installed 1/2 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures
 - awstools.powershell (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\AWSTools.Powershell\tools\chocolateyInstall.ps1'.

Reproduction Steps

Run 'Install-Module -Name AWSPowerShell -Force'

Possible Solution

No response

Additional Information/Context

I raised an issue on the Choco GitHub page, and I they said the problem sits with AWS as they should be updating their choco package to not use the deprecated commands it is currently using.

AWS Tools for PowerShell version used

I cannot install the tools at all, but I imagine 'Install-Module -Name AWSPowerShell -Force' is trying to install the latest version

PowerShell version used

PowerShell v5.1.14409.20180811

Operating System and version

Windows Server 2016

[ashishdhingra]

Hi @campanellaf,

Good morning.

Thanks for opening the issue. AWS Tools for PowerShell does not use chocolatey which appears to be 3rd party package manager for Windows. By default, the AWS Tools for PowerShell gets installed under <<UserDirectory>>\Documents\PowerShell\ or C:\Program Files\WindowsPowerShell\Modules, without any trace for chocolatey. If you look at your installation path, it is C:\ProgramData\chocolatey, which appears to be managed by chocolatey package manager. I'm unsure how chocolatey package manager works and how lib\AWSTools.Powershell\tools\chocolateyInstall.ps1 was generated. This is not the result of the default AWS Tools for PowerShell install, may be managed by this 3rd party package manager.

For testing purposes,
NOTE: On Windows Server 2016, you might have to use command [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 in Windows PowerShell for any installation issues.

• Launched new EC2 instance (Windows Server 2016).

• Executed command from Windows PowerShell (launched as Administrator) Install-Module -Name AWSPowerShell -Force.
  RESULT: The AWSPowerShell module got installed under C:\Program Files\WindowsPowerShell\Modules. There is no trace of chocolatey in C:\Program Files\WindowsPowerShell\Modules\AWSPowerShell\4.1.81.

• Uninstalled AWSPowerShell module using command Uninstall-Module AWSPowerShell.

• Installed chocolatey package manager using PowerShell instructions at https://docs.chocolatey.org/en-us/choco/setup#installing-chocolatey

• Closed and relaunched Windows PowerShell (as Administrator).

• Executed command from Windows PowerShell Install-Module -Name AWSPowerShell -Force.
  RESULT: The AWSPowerShell module again gets installed under C:\Program Files\WindowsPowerShell\Modules. There is no trace of chocolatey in C:\Program Files\WindowsPowerShell\Modules\AWSPowerShell\4.1.81.

• Uninstalled AWSPowerShell module using command Uninstall-Module AWSPowerShell.

• Executed command choco install awstools.powershell (based on https://community.chocolatey.org/packages/AWSTools.Powershell).
  RESULT: choco command appears to install AWS PowerShell module (old version) at C:\ProgramData\chocolatey\lib\AWSTools.Powershell which contains C:\ProgramData\chocolatey\lib\AWSTools.Powershell\tools\ chocolateyInstall.ps1. Then it throws installation error ERROR: The term 'Write-ChocolateyFailure' is not recognized as the name of a cmdlet, function from the log.

So looks like the community submitted AWSPowerShell chocolatey package has the issue (which also might be out of date and installing older version of AWSPowerShell module). This 3rd party chocolatey package is not maintained or supported by AWS team.

The recommended and supported way to install AWS Tools for PowerShell is to use official AWS sources (refer Installing the AWS Tools for PowerShell on Windows). I'm unsure how your systems are configured and how chocolatey package manager is integrated with Windows PowerShell. You may try uninstalling chocolatey (https://docs.chocolatey.org/en-us/choco/uninstallation) if it is not being used for any other package management.

Thanks,
Ashish

[ghost]

To provide a bit more context, we are creating custom AMIs using sceptre, and the AWS Powershell Tools are installed during the preparation phase using the following script:

$VerbosePreference = "Continue"
$ErrorActionPreference = "Stop"

try {
    $date = Get-Date
    Write-Verbose "---->[$date] Installing AWSPowerShell module"
    Install-Module -Name AWSPowerShell -Force
}
catch {
    Write-Error "Something went wrong running Install-Module -Name AWSPowerShell -Force:"
    Write-Error $_
}

$date = Get-Date
Write-Verbose "---->[$date] Done!"

This results in the following output:

amazon-ebs: [05/10/2022 17:01:05] Installing AWSPowershellTools
amazon-ebs: Chocolatey v1.1.0
amazon-ebs: Installing the following packages:
amazon-ebs: awstools.powershell
amazon-ebs: By installing, you accept licenses for the packages.
amazon-ebs: Progress: Downloading PowerShell 5.1.14409.20180811... 100%
amazon-ebs: Progress: Downloading AWSTools.Powershell 1.1.1120.20130916... 100%
amazon-ebs:
amazon-ebs: PowerShell v5.1.14409.20180811 [Approved]
amazon-ebs: powershell package files install completed. Performing other installation steps.
amazon-ebs: Running on: Windows Server 2016 Datacenter, (ServerDatacenter), Windows Kernel: 10.0.14393
amazon-ebs: Installing for OS: Windows 10/Server 2016
amazon-ebs: WARNING: Windows 10 / Server 2016 has WMF/PowerShell 5 pre-installed which is maintained by Windows Updates.
amazon-ebs:  The install of powershell was successful.
amazon-ebs:   Software install location not explicitly set, it could be in package or
amazon-ebs:   default install location of installer.
amazon-ebs:
amazon-ebs: AWSTools.Powershell v1.1.1120.20130916 [Approved]
amazon-ebs: awstools.powershell package files install completed. Performing other installation steps.
amazon-ebs: WARNING: Url has SSL/TLS available, switching to HTTPS for download
amazon-ebs: Downloading AWSTools.Powershell
amazon-ebs:   from 'https://sdk-for-net.amazonwebservices.com/latest/AWSToolsAndSDKForNet.msi'
amazon-ebs: Progress: 100% - Completed download of C:\Users\Administrator\AppData\Local\Temp\chocolatey\AWSTools.Powershell\1.1.1120.20130916\AWSToolsAndSDKForNet_sdk-3.7.270.0_ps-4.1.80.0_tk-1.14.5.1.msi (159.19 MB).
amazon-ebs: Download of AWSToolsAndSDKForNet_sdk-3.7.270.0_ps-4.1.80.0_tk-1.14.5.1.msi (159.19 MB) completed.
amazon-ebs: Installing AWSTools.Powershell...
amazon-ebs: AWSTools.Powershell has been installed.
amazon-ebs: WARNING: Write-ChocolateySuccess was removed in Chocolatey CLI v1, and have no functionality any more. If you are the maintainer, please remove it from from your package file.
amazon-ebs: WARNING: If you are not the maintainer, please contact the maintainer to update the AWSTools.Powershell package.
amazon-ebs:   awstools.powershell may be able to be automatically uninstalled.
amazon-ebs:  The install of awstools.powershell was successful.
amazon-ebs:   Software installed as 'msi', install location is likely default.
amazon-ebs:
amazon-ebs: Chocolatey installed 2/2 packages.
amazon-ebs:  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
amazon-ebs: VERBOSE: ---->[05/10/2022 17:02:07] Done!

We are not calling choco explicitly in the script, which is what led me to thinking that the command Install-Module -Name AWSPowerShell -Force is using choco behind the scenes to download the latest version of the tool and install it.

Do you have any idea how/why choco is being used to install the AWS Powershell Tools?

It is also worth mentioning that I was able to work around the issue by installing the chocolatey-compatibility.extension module

[ghost]

Mistery solved - the script we are using to instal the tool is actually not the one I reported above. The script we are using is explicitly using choco to install the tool, which explains the above.

Thank you very much for replying and providing the explanation you gave above!

[github-actions[bot]]

Hello! Reopening this discussion to make it searchable.