Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Implementation #302

Merged
merged 12 commits into from
Mar 7, 2019
Merged

Log Implementation #302

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
24975e7
Initial winston logging implementation
bryceitoc9 Feb 20, 2019
6aed477
Added Command Palette command for opening logfile, added log level se…
bryceitoc9 Feb 21, 2019
8c69808
Using winston transport for output channel
bryceitoc9 Feb 22, 2019
68882f1
Added logger framework, converted console calls to logger calls, adde…
bryceitoc9 Mar 1, 2019
f8aa418
Changed logfile timestamp formatting
bryceitoc9 Mar 1, 2019
02044a4
Minor tweaks and additional comments
bryceitoc9 Mar 4, 2019
783d6ca
Merging deploy
bryceitoc9 Mar 4, 2019
0d99bf7
Fixing a test to ensure logger is active during its run
bryceitoc9 Mar 4, 2019
1de031d
Removing extraneous function
bryceitoc9 Mar 5, 2019
3ab48f5
Addressing feedback--ensuring registerCommand is called only once
bryceitoc9 Mar 6, 2019
a3d629d
Merging develop
bryceitoc9 Mar 6, 2019
0dc2134
Finishing merge from develop...
bryceitoc9 Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
182 changes: 171 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 27 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
"onCommand:aws.samcli.detect",
"onCommand:aws.samcli.validate.version",
"onCommand:aws.lambda.createNewSamApp",
"onDebugInitialConfigurations"
"onDebugInitialConfigurations",
"onCommand:aws.viewLogs"
],
"main": "./out/src/extension",
"contributes": {
Expand Down Expand Up @@ -64,6 +65,23 @@
"default": 30000,
"markdownDescription": "%AWS.configuration.description.samcli.debug.attach.timeout%"
},
"aws.logLevel": {
"type": "string",
"default": "info",
"enum": [
"error",
"warn",
"info",
"verbose"
],
"enumDescriptions": [
"Errors Only",
"Errors and Warnings",
"Errors, Warnings, and Info",
"Errors, Warnings, Info, and Verbose"
],
"markdownDescription": "%AWS.configuration.description.logLevel%"
},
"aws.telemetry": {
"type": [
"string",
Expand Down Expand Up @@ -256,6 +274,11 @@
"command": "aws.showErrorDetails",
"title": "%AWS.command.showErrorDetails%",
"category": "AWS"
},
{
"command": "aws.viewLogs",
"title": "%AWS.command.viewLogs%",
"category": "AWS"
}
]
},
Expand Down Expand Up @@ -317,10 +340,13 @@
"semver": "^5.6.0",
"sleep-promise": "^8.0.1",
"tcp-port-used": "^1.0.1",
"triple-beam": "^1.3.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was removed, but it looks like it made its way back in. Will delete.

"typescript": "^3.1.3",
"uuid": "^3.3.2",
"vscode-nls": "^3.2.4",
"vue": "^2.5.16",
"winston": "^3.2.1",
"winston-transport": "^4.3.0",
"xml2js": "^0.4.19"
}
}
Loading