fix: Fixed an issue where custom AmazonEC2Client.DryRun() method was not working for non-BCL targets. Also included this method in IAmazonEC2 interface.

[ashishdhingra]

Description

fix: Fixed an issue where custom AmazonEC2Client.DryRun() method was not working for non-BCL targets. Also included this method in IAmazonEC2 interface.

This PR addressed following:

• Includes DryRun() method as part of IAmazonEC2 interface for easier mock-ability.
• For non-BCL targets it includes NonPublic methods in reflection search. Kindly note that we need to explicitly use BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic.

Based on discussion with @normj, we should perhaps deprecate/obsolete this method in V4 and remove customization in ec2.customizations.json to not exclude DryRun property from request models (this was done due to legacy reasons when EC2 code was hand-coded). Created separate backlog item for it in Input queue.

Motivation and Context

Issue #3595

Testing

• Tested locally using below code:

  IAmazonEC2 ec2Client = new AmazonEC2Client();
  var ec2DryRunRespose = ec2Client.DryRun(new StartInstancesRequest { InstanceIds = new() { "<<EC2InstanceID>>" } });

  No unit test/integration test was added since we would need to spin up new EC2 instance. We would also deprecate this method in V4.

• Catapult dry-run completed successfully.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license

[dscpinheiro]

I don't quite understand why you had to add BindingFlags.NonPublic, there are no private methods added in this PR.

I wonder if this could break AOT applications (probably need @normj's input here).

[ashishdhingra]

We needed internal members to access synchronous versions of methods which are marked as internal. I had discussed this with @normj in person. 😊