Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normj/v4-smoketests #3576

Closed
wants to merge 163 commits into from
Closed

normj/v4-smoketests #3576

wants to merge 163 commits into from

Conversation

AlexDaines
Copy link
Contributor

@AlexDaines AlexDaines commented Dec 12, 2024 •
edited
Loading

Description

Implements the generator for smoke tests v2 format based on the new smoke-2.json schema. Key features:

  • Supports all configuration options from the smoke-2.json schema
  • Handles complex input types including arrays and nested objects
  • Generates both success and failure test cases
  • Includes proper test categorization
  • Manages special cases for Tags and Includes objects

Questions for review:

  1. Special case handling for Tags/Includes - should this be more generic?
  2. Configuration defaults - should we explicitly set schema defaults?
  3. Error handling - any additional checks needed beyond ErrorCode?
  4. Input validation - should we validate against operation parameters?
  5. Test categorization - any additional AWS-specific categories needed?

Motivation and Context

This implementation supports the new smoke tests format (smoke-2.json) which provides more configuration options and better structure for test cases. The generator creates test files that:

  • Allow per-test configuration
  • Support all endpoint configuration options
  • Handle complex input structures
  • Provide proper error handling and validation

Testing

  • Verified generation with ACM service model
  • Tested various scenarios including:
    • Success and failure cases
    • Complex input structures (arrays, nested objects)
    • Special cases (Tags, Includes)
    • Edge cases (null values, empty strings)
    • All configuration options
  • Generated tests compile successfully

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

dscpinheiro and others added 30 commits February 22, 2024 13:52
@dscpinheiro
Remove net35 assemblies from nuspec templates (#3196)
828d7e0 
* refactor: Remove net35 assemblies from nuspec templates
* refactor: Remove net35 from CrtIntegration nuspec
@dscpinheiro
refactor: Remove Net35 from manifest file
fa3b70e
@dscpinheiro
Update manifest file to use net462 instead of net45 (#3199)
09cd499 
* refactor: Update manifest file to use net462 instead of net45
* refactor: Remove Travis solution from the generator
@dscpinheiro
Update integration test projects to target net462 (#3202)
2d58656 
* refactor: Update integration test projects to target net462
* refactor: Rename integration test class
* refactor: Remove dynamoDBContext from AppConfig files (except for DynamoDB)
@dscpinheiro
refactor: Update CSM projects to target net462 (#3204)
266e4b7
@dscpinheiro
refactor: Add step in the generator to delete net35 and net45 legacy …
c4f5c13 
…files (#3207)
@dscpinheiro
Update SDK to use BCL constant instead of BCL45 (#3208)
e58bd59 
* refactor: Rename bcl45 to bcl and remove bcl35 references
* refactor: Remove bcl35 references from S3 solution
* refactor: Add missing exceptions from S3 and S3Control
@dscpinheiro
Update remaining BCL45 constants (#3210)
39a6959 
* refactor: Update post-generator step to also delete bcl45 folders
* refactor: Update BCL constant in integration test projects
* refactor: Update BCL references in custom unit tests and DynamoDB
@dscpinheiro
Update test namespaces not to use 35 or 45 (#3212)
912a09e 
* refactor: Update generated namespaces not to use 35
* refactor: Update test namespaces not to use 35 or 45
@dscpinheiro
Remove AWS_APM_API references (#3216)
f151c05 
* refactor: Remove all AWS_APM_API references
* refactor: Rename remaining bcl45 folders
@normj
Generator changes for using nullable value types
21081fa
@normj
Core changes required for supporting nullable value types from the ge…
11667be 
…nerator
@normj
S3 manual changes for nullable value types
355f12b
@normj
Nullable changes in custom code for CognitoIdentity
29784c3
@normj
Nullable changes in custom code for DynamoDB
c95aea4
@normj
Nullable changes in custom code for EC2
31e05f8
@normj
Nullable changes in custom code for SecurityToken
f40c88b
@normj
Nullable changes in custom code for SSO
25fae3e
@normj
Nullable changes in custom code for SSOOIDC
5b82177
@normj
Update tests for nullable changes
209b818
@normj
Consistently use HasValue in nullable types in StringUtils
1b32de2
@normj
Commit generated files after generator change
fc665f0
@normj
Add .NET Standard 2.0 System packages to .NET Framework .NET Standard…
64da6cf 
… 2.0 targets (#3224)
@normj
Merge commit '884027ba6daa81bccda208509604623b140700db'
d901452
@normj
Change AWSConfigs.InitializeCollections to false for V4
e16e5e9
@dscpinheiro
Remove Legacy Enums (#3235)
03cf91a 
* refactor: Remove RequestRetryMode.Legacy and DefaultConfigurationMode.Legacy
* chore: Add generated files
@dscpinheiro
Update STS to always use regional endpoints (#3236)
d6bd84d 
* refactor: Remove legacy option from STS Regionalized endpoints
* refactor: Remove STS legacy endpoint option
* chore: Add generated files
* refactor: Remove default-region from STS metadata.json
@danielmarbach
Replace custom implementation of Join with string.Join (#3291)
4c66d38
@danielmarbach
Replace custom implementation of CopyStream with CopyTo (#3292)
815db56
@normj
Merge commit '875eb2d705bb0cdd8b8b602780494e7b8e0f13d3'
622e523
dscpinheiro and others added 25 commits September 27, 2024 13:56
@dscpinheiro
chore: Update versioning for preview 3
1e53c39
@dscpinheiro
fix: Check for null collections in AmazonEC2ResponseHandler
47ffb01
@dscpinheiro
Merge commit 'd837e1d9b57336394b2832b28a2a9052473dd618'
a78abbd
@dscpinheiro
chore: Update generated files
2d837b2
@dscpinheiro
fix: Remove extra character from user-agent header
bc492c8
@dscpinheiro
Merge pull request #3491 from aws/v4-development-merge
5dcde09 
Merge V3 into V4 prior to third preview
@aws-sdk-dotnet-automation
Commit version number update changes
bb6db11
@muhammad-othman
Support cref and path attributes in inheritdoc tags
ec27560
@muhammad-othman
Merge pull request #3498 from aws/muhamoth/DOTNET-7684-Support-More-C…
bcd8eb9 
…omplicated-inheritdoc-Syntax

Docs: [API Ref] Support More Complicated <inheritdoc/> Syntax
@peterrsongg
Populate request property in request handler (#3504)
06d8d57 
* re-populate request property when instantiating WebServiceRequestEventArgs

* add devconfig
@dscpinheiro
chore: Update System.Text.Json dependency
f73b3c3
@dscpinheiro
chore: Update versioning for preview 4
e3c7a62
@aws-sdk-dotnet-automation
Commit version number update changes
a0f7453
@peterrsongg
Make InternalSDKUtils AOT compatible in V4 (#3516)
5de9e0e 
* fix #3497. Make InternalSDKUtils aot compatible in v4
@peterrsongg
fix: update AWS_S3_USE_ARN_REGION to take precedence over value set i… (
4af5116 
#3513)

* fix: Update AWS_S3_USE_ARN_REGION environment variable to take precedence over s3_use_arn_region option in the config file.
@peterrsongg
Do not trim leading slashes for copy object and copy part operations (#…
e34641f 
…3532)

* Remove disabletrimmingleadingslash flag for copyobject and copypart operations
@96malhar
feat: Add observability to V4 DynamoDB HLL
15400fa
@normj
Support decimal precision for Document.FromJson and ToJson by using S…
0f1a82e 
…ystem.Text.Json instead of LitJson (#3534)
@dscpinheiro
Merge commit 'acae479fe47dc2583f625fe9f3d68413573ee15b'
3ff1cd9
@dscpinheiro
chore: Add generated files
c44be2c
@dscpinheiro
fix: Manual changes after merge resolution
5aee938
@dscpinheiro
refactor: Add reason for skipped tests
042cf27
@dscpinheiro
Merge pull request #3556 from aws/v4-development-merge
82c7d34
@normj
Add code path to generate the skeleton of a smoke test v2
88e86a5
@AlexDaines
Generator implementation for V2 smoke tests for C2J files.
c820b8c
@AlexDaines AlexDaines marked this pull request as ready for review December 12, 2024 17:19
@AlexDaines AlexDaines changed the base branch from main to main-staging December 12, 2024 17:30
@AlexDaines AlexDaines marked this pull request as draft December 12, 2024 17:32
@AlexDaines AlexDaines closed this Dec 12, 2024
@AlexDaines
Copy link
Contributor Author

Closing in favor of #3577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.