Uses POST instead of GET for CloudSearch Domain search operation #976
Conversation
| req = new AWS.CloudSearchDomain({endpoint: 'host.domain.com'}).search({query: 'foo', cursor: 'initial', queryOptions: '{}'}).build() | ||
| req = new AWS.CloudSearchDomain({endpoint: 'host.domain.com'}) | ||
| .search({query: 'foo', cursor: 'initial', queryOptions: '{}'}) | ||
| .removeListener('build', AWS.CloudSearchDomain.prototype.convertGetToPost) |
There was a problem hiding this comment.
Why is this listener being removed in the test?
There was a problem hiding this comment.
This test is testing whether the query string is alphabetically sorted by its field names. The listener that I'm removing here previously did not exist, as it was added as part of this PR, so I'm not removing something that used to be there. Since the listener I added in this PR changes the GET request to a POST, there is no longer a query string, and the test cannot check if it's alphabetically sorted. Therefore, I removed the listener so that just for the purpose of this test, the request is still a GET and has a query string. The other two options I have if I don't remove this listener is to switch the test to use a different operation (I could use suggest instead of search) or to remove this test altogether.
12c31bb to
be1052c
Compare
|
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Converts search requests to CloudSearch Domain to use POST instead of GET to lift restriction on query length. Resolves #614