Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update vitest to 2.1.8 #6780

Merged
merged 4 commits into from
Jan 8, 2025
Merged

test: update vitest to 2.1.8 #6780

merged 4 commits into from
Jan 8, 2025

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jan 7, 2025

Issue

see also smithy-lang/smithy-typescript#1496

updates to latest vitest from Dec 2024

@kuhe kuhe requested a review from a team as a code owner January 7, 2025 21:45
@kuhe kuhe changed the title vitest test: update vitest to 2.1.8 Jan 7, 2025
@kuhe
Copy link
Contributor Author

kuhe commented Jan 8, 2025

Ran into this issue: capricorn86/happy-dom#1042

// TODO(vitest)
// Caused by: RequestContentLengthMismatchError: Request body length does not match content-length header
// only in vitest + happy-dom.
it.skip("should succeed with blob body", async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrading vitest and happy-dom, blob body started working and ReadableStream stopped working 🙃

@kuhe kuhe merged commit 6858c7e into aws:main Jan 8, 2025
4 checks passed
@kuhe kuhe deleted the vitest branch January 8, 2025 20:19
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants