Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Presigner #266

Merged
merged 10 commits into from
Jun 4, 2019
Merged

S3 Presigner #266

merged 10 commits into from
Jun 4, 2019

Conversation

AllanZhengYP
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP changed the title [WIP]S3 Presigner S3 Presigner May 31, 2019
@codecov-io
Copy link

codecov-io commented May 31, 2019

Codecov Report

Merging #266 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   91.38%   91.38%   +<.01%     
==========================================
  Files         265      265              
  Lines        6070     6071       +1     
  Branches     1364     1364              
==========================================
+ Hits         5547     5548       +1     
  Misses        523      523
Impacted Files Coverage Δ
...ges/service-types-generator/src/internalImports.ts 100% <ø> (ø) ⬆️
packages/util-format-url/src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515f2a5...1297e54. Read the comment docs.

@AllanZhengYP AllanZhengYP requested a review from trivikr June 3, 2019 18:39
@AllanZhengYP AllanZhengYP merged commit 3f00b99 into aws:master Jun 4, 2019
@lock
Copy link

lock bot commented Jun 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants