Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to handleAsync #4023

Merged
merged 1 commit into from
May 17, 2023
Merged

Switch to handleAsync #4023

merged 1 commit into from
May 17, 2023

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented May 17, 2023

Motivation and Context

Update the fix from #4009.

Modifications

whenCompleteAsync is incorrect because if the response handler future completes exceptionally, then the returned future will also be completed with that exception which will incorrectly trigger a synchronous completion for the response future.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir requested a review from a team as a code owner May 17, 2023 17:50
@dagnir dagnir force-pushed the dongie/use-handleasync branch from ac5d23f to 33a7a77 Compare May 17, 2023 17:53
whenCompleteAsync is incorrect because if the response handler future completes
exceptionally, then the returned future will also be completed with that
exception which will incorrectly trigger a synchronous completion for the
response future.
@dagnir dagnir force-pushed the dongie/use-handleasync branch from 33a7a77 to a09b84b Compare May 17, 2023 18:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.4% 94.4% Coverage
0.0% 0.0% Duplication

@dagnir dagnir merged commit 1a23009 into master May 17, 2023
@dagnir dagnir deleted the dongie/use-handleasync branch May 18, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants