-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change STANDARD mode retry count for DynamoDB to match LEGACY as V1 #2324
Conversation
...ces/dynamodb/src/main/java/software/amazon/awssdk/services/dynamodb/DynamoDbRetryPolicy.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2324 +/- ##
============================================
+ Coverage 77.64% 77.66% +0.02%
Complexity 366 366
============================================
Files 1239 1239
Lines 39033 39035 +2
Branches 3081 3081
============================================
+ Hits 30307 30318 +11
+ Misses 7256 7248 -8
+ Partials 1470 1469 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/** | ||
* Default max retry count for DynamoDB client, when using the STANDARD retry mode. | ||
**/ | ||
private static final int STANDARD_MAX_ERROR_RETRY = 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The legacy max error retry is 8 in v2, so the standard mode should be the same. We can probably just reuse the existing LEGACY_MAX_ERROR_RETRY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated STANDARD_MAX_ERROR_RETRY as 8 , I would like to keep a separate Constant for Standard mode to avoid confusions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it private static final int STANDARD_MAX_ERROR_RETRY = LEGACY_MAX_ERROR_RETRY
? My concern is that if we ever change the legacy max error retry (although not likely), we might forget to change both places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -0,0 +1,6 @@ | |||
{ | |||
"category": "AWS SDK for Java v2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, the category should be Amazon DynamoDB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
"category": "AWS SDK for Java v2", | ||
"contributor": "", | ||
"type": "feature", | ||
"description": "Change STANDARD mode retry count which was 8 for DynamoDB to match LEGACY retry count which is 10." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description can be updated, as the LEGACY retry count is 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Kudos, SonarCloud Quality Gate passed! |
…66c26af80 Pull request: release <- staging/8474511c-601d-4baa-b8f5-2f366c26af80
Description
Change STANDARD mode retry count for DynamoDB to match LEGACY same as in V1
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsLicense