Add log level check to gate IMDSv1 fallback warning #5131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #5116
This PR updates the logging behavior in the EC2Metadata token provider (
token_provider.go
). It modifies the conditions under which the warning message about falling back to IMDSv1 is logged.Changes
The warning "WARN: failed to get session token, falling back to IMDSv1" in the
fetchTokenHandler
method is now conditioned on theLogLevel
being set toLogDebugWithDeprecated
.This update prevents the warning from being logged when the
LogLevel
is configured to suppress such messages.Testing
This testing setup demonstrates the modified behavior of the EC2Metadata token provider, using a custom HTTP transport to simulate conditions that trigger a fallback to IMDSv1. The test verifies that the warning message is conditionally logged based on the
LogLevel
setting, ensuring it aligns with the configured log suppression.