Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIPS & DualStack Endpoint Resolver Support #3938

Merged
merged 7 commits into from
Nov 5, 2021

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Jun 1, 2021

Support has been added for an updated endpoints.json model which contains modeled endpoint data for service dual-stack and FIPS endpoints.

Additionally, this support removes the need for the dual-stack customization in place for S3 and S3 Control service clients, and simplifies FIPS logic.

@skmcgrail skmcgrail requested review from jasdel and skotambkar June 1, 2021 20:16
@skmcgrail skmcgrail marked this pull request as draft June 1, 2021 20:17
@skmcgrail
Copy link
Member Author

Should not be merged until an updated endpoints model file is provided.

@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch 3 times, most recently from 73f46fe to b44324a Compare June 2, 2021 22:24
@skmcgrail
Copy link
Member Author

skmcgrail commented Jun 4, 2021

Changes that were included in the last force push:

  • Constants have been renamed to DualStackEndpointUnset, DualStackEndpointEnabled, DualStackEndpointDisabled.

@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch 3 times, most recently from 6bcb213 to 2080ebd Compare June 24, 2021 18:25
aws/config.go Outdated Show resolved Hide resolved
aws/config.go Outdated Show resolved Hide resolved
aws/config.go Outdated Show resolved Hide resolved
aws/endpoints/decode_test.go Outdated Show resolved Hide resolved
aws/endpoints/endpoints.go Outdated Show resolved Hide resolved
aws/endpoints/endpoints.go Outdated Show resolved Hide resolved
aws/endpoints/v3model.go Outdated Show resolved Hide resolved
aws/endpoints/v3model_shared_test.go Outdated Show resolved Hide resolved
aws/endpoints/v3model.go Outdated Show resolved Hide resolved
@skotambkar
Copy link
Contributor

Looks good, just minor questions/suggestions.

@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch from b7e4e3e to 883f062 Compare July 2, 2021 00:23
@skmcgrail skmcgrail requested a review from skotambkar July 2, 2021 00:30
@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch from 883f062 to f7cebdd Compare July 2, 2021 00:34
@hakman
Copy link

hakman commented Sep 18, 2021

@skmcgrail Any plans to merge this in the near future? Would be helpful to get the EBS CSI driver with IPv6.

@skmcgrail skmcgrail changed the title UseDualStackEndpoint Endpoint Resolver Support FIPS & DualStack Endpoint Resolver Support Nov 1, 2021
@skmcgrail skmcgrail marked this pull request as ready for review November 1, 2021 20:32
aws/session/session.go Show resolved Hide resolved
internal/s3shared/resource_request.go Outdated Show resolved Hide resolved
@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch 2 times, most recently from d34b38f to d8e3630 Compare November 4, 2021 00:10
@skmcgrail skmcgrail requested a review from jasdel November 4, 2021 17:41
@skmcgrail skmcgrail merged commit 2582633 into aws:main Nov 5, 2021
aws-sdk-go-automation pushed a commit that referenced this pull request Nov 8, 2021
===

### Service Client Updates
* `service/chime-sdk-meetings`: Updates service API and documentation
* `service/ec2`: Updates service API and documentation
  * This release adds internal validation on the GatewayAssociationState field
* `service/sagemaker`: Updates service API and documentation
  * SageMaker CreateEndpoint and UpdateEndpoint APIs now support additional deployment configuration to manage traffic shifting options and automatic rollback monitoring. DescribeEndpoint now shows new in-progress deployment details with stage status.
* `service/wafv2`: Updates service API and documentation

### SDK Features
* Support has been added for configuring endpoints with requirements such as FIPS and DualStack. ([#3938](#3938))
  * `AWS_USE_FIPS_ENDPOINT` and `AWS_USE_DUALSTACK_ENDPOINT` can be set to `true` or `false` in the environment to indicate an endpoint with the respective characteristic must be resolved.
  * `use_fips_endpoint` and `use_dualstack_endpoint` can be set to `true` or `false` in the shared config file to indicate an endpoint with the respective characteristic must be resolved.
  * Programmatic configuration of FIPS and DualStack endpoint resolution.
  * For more information see the `aws/session` package documentation.
aws-sdk-go-automation added a commit that referenced this pull request Nov 8, 2021
Release v1.42.0 (2021-11-08)
===

### Service Client Updates
* `service/chime-sdk-meetings`: Updates service API and documentation
* `service/ec2`: Updates service API and documentation
  * This release adds internal validation on the GatewayAssociationState field
* `service/sagemaker`: Updates service API and documentation
  * SageMaker CreateEndpoint and UpdateEndpoint APIs now support additional deployment configuration to manage traffic shifting options and automatic rollback monitoring. DescribeEndpoint now shows new in-progress deployment details with stage status.
* `service/wafv2`: Updates service API and documentation

### SDK Features
* Support has been added for configuring endpoints with requirements such as FIPS and DualStack. ([#3938](#3938))
  * `AWS_USE_FIPS_ENDPOINT` and `AWS_USE_DUALSTACK_ENDPOINT` can be set to `true` or `false` in the environment to indicate an endpoint with the respective characteristic must be resolved.
  * `use_fips_endpoint` and `use_dualstack_endpoint` can be set to `true` or `false` in the shared config file to indicate an endpoint with the respective characteristic must be resolved.
  * Programmatic configuration of FIPS and DualStack endpoint resolution.
  * For more information see the `aws/session` package documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants