Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/credentials/stscreds: Add STS and Assume Role specific retries #2752

Merged
merged 3 commits into from
Aug 14, 2019

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Aug 13, 2019

Adds retries to specific STS API errors to the STS AssumeRoleWithWebIdentity credential provider, and STS API operations in general.

@jasdel jasdel added the needs-review This issue or pull request needs review from a core team member. label Aug 13, 2019
@jasdel jasdel requested a review from skotambkar August 13, 2019 16:52
@jasdel jasdel self-assigned this Aug 13, 2019

### SDK Bugs
* `private/model/api`: Fix broken shape stutter rename during generation ([#2747](https://github.com/aws/aws-sdk-go/pull/2747))
* Fixes the SDK's code generation incorrectly renaming types and operations. The code generation would incorrectly rename an API type by removing the service's name from the type's name. This was done without checking for if a type with the new name already existed. Causing the SDK to replace the existing type with the renamed one.
* Fixes [#2741](https://github.com/aws/aws-sdk-go/issues/2741)
* `private/model/api`: Fix API doc being generated with wrong value ([#2748](https://github.com/aws/aws-sdk-go/pull/2748))
* Fixes the SDK's generated API documentation for structure member being generated with the wrong documentation value when the member was included multiple times in the model doc-2.json file, but under different types.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: white space

jasdel added 3 commits August 14, 2019 15:47
Adds retries to specific STS API errors to the STS
AssumeRoleWithWebIdentity credential provider, and STS API operations in
general.
@jasdel jasdel force-pushed the feat/10_STSRetries branch from 0419454 to bb34ad0 Compare August 14, 2019 22:48
@jasdel jasdel merged commit d8409ae into aws:master Aug 14, 2019
@jasdel jasdel deleted the feat/10_STSRetries branch August 14, 2019 22:56
@aws-sdk-go-automation aws-sdk-go-automation mentioned this pull request Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants