dynamodbattribute panics unmarshaling number into string typedef

[rittneje]

Confirm by changing [ ] to [x] below to ensure that it's a bug:

• I've gone though Developer Guide and API reference
• I've checked AWS Forums and StackOverflow for answers
• I've searched for previous similar issues and didn't find any solution

Describe the bug

Unmarshaling an AttributeValue number into a string typedef panics.

aws-sdk-go/service/dynamodb/dynamodbattribute/decode.go

Lines 314 to 319 in 99a46db

	case reflect.String:
	if v.Type() == numberType { // Support Number value type
	v.Set(reflect.ValueOf(Number(*n)))
	return nil
	}
	v.Set(reflect.ValueOf(*n))

This should use v.SetString(*n) instead of v.Set(reflect.ValueOf(*n))

Version of AWS SDK for Go?

v1.38.65

Version of Go (go version)?

1.15.13

To Reproduce (observed behavior)

package main

import (
	"fmt"
	"log"

	"github.com/aws/aws-sdk-go/aws"
	"github.com/aws/aws-sdk-go/service/dynamodb"
	"github.com/aws/aws-sdk-go/service/dynamodb/dynamodbattribute"
)

type Foo string

type Bar struct {
	F Foo
}

func main() {
	m := map[string]*dynamodb.AttributeValue{
		"F": &dynamodb.AttributeValue{
			N: aws.String("12345"),
		},
	}

	var b Bar

        // This line panics.
	err := dynamodbattribute.UnmarshalMap(m, &b)
	if err != nil {
		log.Println(err)
	} else {
		fmt.Println(b)
	}
}

This yields "panic: reflect.Set: value of type string is not assignable to type main.Foo"

For reference: https://play.golang.org/p/uTdKemtyvLv

[rittneje]

ping @jasdel

[rittneje]

@jasdel @KaibaLopez Are there plans to fix this?

[rittneje]

@jasdel @KaibaLopez This bug was filed almost two months ago.

[jasdel]

Thanks for reaching out @rittneje and reporting this issue. I've been able to reproduce this issue. It looks like the issue that is causing Set not to work is the string alias being used. The Unmarshaler should be able to handle aliased types. SetString would fix this, and it looks like this pattern is used for the other basic types.

Will investigate if there are other cases this is happening.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.