-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Presigned URL generation for Neptune and DocDB CopyDBClusterSnapshot …
…& CreateDBCluster (#3782)
- Loading branch information
Showing
9 changed files
with
695 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
### SDK Features | ||
|
||
### SDK Enhancements | ||
* `service/neptune`: Support for PreSignedUrl generation for CopyDBClusterSnapshot and CreateDBCluster operations. ([#3782](https://github.com/aws/aws-sdk-go/pull/3782)) | ||
* `service/docdb`: Support for PreSignedUrl generation for CopyDBClusterSnapshot and CreateDBCluster operations. ([#3782](https://github.com/aws/aws-sdk-go/pull/3782)) | ||
|
||
### SDK Bugs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
package docdb | ||
|
||
import ( | ||
"time" | ||
|
||
"github.com/aws/aws-sdk-go/aws" | ||
"github.com/aws/aws-sdk-go/aws/awsutil" | ||
"github.com/aws/aws-sdk-go/aws/endpoints" | ||
"github.com/aws/aws-sdk-go/aws/request" | ||
) | ||
|
||
func init() { | ||
ops := []string{ | ||
opCopyDBClusterSnapshot, | ||
opCreateDBCluster, | ||
} | ||
initRequest = func(r *request.Request) { | ||
for _, operation := range ops { | ||
if r.Operation.Name == operation { | ||
r.Handlers.Build.PushFront(fillPresignedURL) | ||
} | ||
} | ||
} | ||
} | ||
|
||
func fillPresignedURL(r *request.Request) { | ||
fns := map[string]func(r *request.Request){ | ||
opCopyDBClusterSnapshot: copyDBClusterSnapshotPresign, | ||
opCreateDBCluster: createDBClusterPresign, | ||
} | ||
if !r.ParamsFilled() { | ||
return | ||
} | ||
if f, ok := fns[r.Operation.Name]; ok { | ||
f(r) | ||
} | ||
} | ||
|
||
func copyDBClusterSnapshotPresign(r *request.Request) { | ||
originParams := r.Params.(*CopyDBClusterSnapshotInput) | ||
|
||
if originParams.SourceRegion == nil || originParams.PreSignedUrl != nil || originParams.DestinationRegion != nil { | ||
return | ||
} | ||
|
||
originParams.DestinationRegion = r.Config.Region | ||
// preSignedUrl is not required for instances in the same region. | ||
if *originParams.SourceRegion == *originParams.DestinationRegion { | ||
return | ||
} | ||
|
||
newParams := awsutil.CopyOf(r.Params).(*CopyDBClusterSnapshotInput) | ||
originParams.PreSignedUrl = presignURL(r, originParams.SourceRegion, newParams) | ||
} | ||
|
||
func createDBClusterPresign(r *request.Request) { | ||
originParams := r.Params.(*CreateDBClusterInput) | ||
|
||
if originParams.SourceRegion == nil || originParams.PreSignedUrl != nil || originParams.DestinationRegion != nil { | ||
return | ||
} | ||
|
||
originParams.DestinationRegion = r.Config.Region | ||
// preSignedUrl is not required for instances in the same region. | ||
if *originParams.SourceRegion == *originParams.DestinationRegion { | ||
return | ||
} | ||
|
||
newParams := awsutil.CopyOf(r.Params).(*CreateDBClusterInput) | ||
originParams.PreSignedUrl = presignURL(r, originParams.SourceRegion, newParams) | ||
} | ||
|
||
// presignURL will presign the request by using SoureRegion to sign with. SourceRegion is not | ||
// sent to the service, and is only used to not have the SDKs parsing ARNs. | ||
func presignURL(r *request.Request, sourceRegion *string, newParams interface{}) *string { | ||
cfg := r.Config.Copy(aws.NewConfig(). | ||
WithEndpoint(""). | ||
WithRegion(aws.StringValue(sourceRegion))) | ||
|
||
clientInfo := r.ClientInfo | ||
resolved, err := r.Config.EndpointResolver.EndpointFor( | ||
EndpointsID, aws.StringValue(cfg.Region), | ||
func(opt *endpoints.Options) { | ||
opt.DisableSSL = aws.BoolValue(cfg.DisableSSL) | ||
opt.UseDualStack = aws.BoolValue(cfg.UseDualStack) | ||
}, | ||
) | ||
if err != nil { | ||
r.Error = err | ||
return nil | ||
} | ||
|
||
clientInfo.Endpoint = resolved.URL | ||
clientInfo.SigningRegion = resolved.SigningRegion | ||
|
||
// Presign a request with modified params | ||
req := request.New(*cfg, clientInfo, r.Handlers, r.Retryer, r.Operation, newParams, r.Data) | ||
req.Operation.HTTPMethod = "GET" | ||
uri, err := req.Presign(5 * time.Minute) // 5 minutes should be enough. | ||
if err != nil { // bubble error back up to original request | ||
r.Error = err | ||
return nil | ||
} | ||
|
||
// We have our URL, set it on params | ||
return &uri | ||
} |
Oops, something went wrong.