aws/signer/v4: Ensure logger option passed down to sign method #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
approved these changes
Dec 10, 2020
skotambkar
reviewed
Dec 10, 2020
skmcgrail
approved these changes
Dec 11, 2020
skotambkar
approved these changes
Dec 11, 2020
1 task
efdcf7d to
b482458
Compare
Ensures the middleware's Logger option value is passed down to the signer's sign method via functional options.
b482458 to
20dc5e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the middleware's Logger option value is passed down to the signer's sign method via functional options.