Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2980

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Update README.md #2980

merged 1 commit into from
Jan 22, 2025

Conversation

andrewwatson
Copy link
Contributor

This fixes #2979

PLEASE READ BEFORE CONTINUING

Do not submit pull requests that directly modify generated source files, e.g. /service/s3/api_client.go. Generated source files will always include an identifying header:

// Code generated by smithy-go-codegen DO NOT EDIT.

Manual changes to these files will be overwritten by code generation that occurs as part of the daily SDK release process.

Do not submit pull requests that directly modify files in the /codegen/sdk-codegen/aws-models folder. These are API model files, owned by each AWS service team, that are updated automatically as part of the daily SDK release process. Local changes to these files will not persist.

If you believe the contents of any of these files need to be changed, please open an issue.

If the PR addresses an existing bug or feature, please reference it here.

To help speed up the process and reduce the time to merge please ensure that Allow edits by maintainers is checked before submitting your PR. This will allow the project maintainers to make minor adjustments or improvements to the submitted PR, allow us to reduce the roundtrip time for merging your request.

Changelog

Make sure that your pull request contains a changelog entry. You can run make external-changelog to create a placeholder entry. See Changelog documents in CONTRIBUTING.md for more details.

You can generate a UUID either by running uuidgen or by visiting a site like uuidtools

@andrewwatson andrewwatson requested a review from a team as a code owner January 22, 2025 14:24
Copy link
Contributor

@lucix-aws lucix-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm

@lucix-aws lucix-aws merged commit d2c7a19 into aws:main Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect link to SDK documentation in README
2 participants