pull retry loop forward to cover everything from resolving auth scheme onward #2966
Conversation
0e53ad6 to
46147c8
Compare
|
@Madrigal You'll want to re-inspect the 1st commit |
|
Integ tests failed again but it looked transient that time - service/wafv2 operation timeouts - retried |
| @@ -53,29 +53,6 @@ type InputMiddlewareOptions struct { | |||
| // AddInputMiddleware adds the middleware for performing checksum computing | |||
| // of request payloads, and checksum validation of response payloads. | |||
| func AddInputMiddleware(stack *middleware.Stack, options InputMiddlewareOptions) (err error) { | |||
| // TODO ensure this works correctly with presigned URLs | |||
| @@ -53,29 +53,6 @@ type InputMiddlewareOptions struct { | |||
| // AddInputMiddleware adds the middleware for performing checksum computing | |||
| // of request payloads, and checksum validation of response payloads. | |||
| func AddInputMiddleware(stack *middleware.Stack, options InputMiddlewareOptions) (err error) { | |||
| // TODO ensure this works correctly with presigned URLs | |||
|
|
|||
| // Middleware stack: | |||
There was a problem hiding this comment.
This is so beyond out-of-date at this point I've just removed it
…up in service client
61f87dc to
42d3a05
Compare
42d3a05 to
a0fcc5d
Compare
| } | ||
| rm.request = req | ||
| return next.HandleSerialize(ctx, in) | ||
| func (c *captureRequest) Do(r *http.Request) (*http.Response, error) { |
There was a problem hiding this comment.
This was just something cool to do, right? Just want to make sure I'm not missing anything
There was a problem hiding this comment.
No, that was for
Fixes tests in service/s3 and service/route53 to correctly inspect the final request. These were technically retrieving the request at the wrong point in time before, it just happened to work because the retry loop hadn't kicked in and cloned the request yet (which it now does, making the captured request pointers stale).
| return err | ||
| } | ||
|
|
||
| stack.Build.Remove("ContentChecksum") |
There was a problem hiding this comment.
I know we had this in place since before you made this change, but is it because ContentChecksum is the older way of doing checksums?
There was a problem hiding this comment.
Yeah, ContentChecksum is the old MD5, which the recent changes to S3 object integrity effectively removes.
Closes #2965
This change is verified by our integration tests.