Skip to content

Commit

Permalink
Fixup for PR feedback missed in 887 (#905)
Browse files Browse the repository at this point in the history
Fixes up documentation comments that were missed in #887
  • Loading branch information
jasdel authored Nov 16, 2020
1 parent a822645 commit df07804
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ public class XmlMemberDeserVisitor implements ShapeVisitor<Void> {
private final boolean isFlattened;

public XmlMemberDeserVisitor(
GenerationContext context, MemberShape member, String dataDest, Format timestampFormat,
GenerationContext context,
MemberShape member,
String dataDest,
Format timestampFormat,
boolean isXmlAttributeMember
) {
this.context = context;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ private void generatesInitializerForOutputVariable(GenerationContext context, Sh
Symbol shapeSymbol = context.getSymbolProvider().toSymbol(shape);

writer.write("var sv $P", shapeSymbol);
// TODO [denseListMap] need to reference if pointable type. Assumes containers are always double pointers.
// TODO this probably isn't true for union types.
writer.openBlock("if *v == nil {", "", () -> {
if (shape.isStructureShape()) {
writer.write("sv = &$T{}", shapeSymbol);
Expand Down

0 comments on commit df07804

Please sign in to comment.