Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix processing lambda container response if nothing returned #5771

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

moelasmar
Copy link
Contributor

@moelasmar moelasmar commented Aug 15, 2023

Which issue(s) does this change fix?

#5766

Why is this change necessary?

to allow customer test lambda functions that does not return any response.

How does it address the issue?

skip parsing the container response as JSON object if there is no response.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@moelasmar moelasmar requested a review from a team as a code owner August 15, 2023 19:21
@moelasmar moelasmar enabled auto-merge August 15, 2023 20:20
@moelasmar moelasmar added this pull request to the merge queue Aug 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 15, 2023
@moelasmar moelasmar added this pull request to the merge queue Aug 16, 2023
Merged via the queue into aws:develop with commit ca6e4e8 Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants