Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Generate
sam deploy
schema #5504feat: Generate
sam deploy
schema #5504Changes from 2 commits
025357d
b6b4e39
3603e12
cee2d3d
16a1740
58faff0
cca9f93
0bd4c58
f07e80d
055b727
c78c617
cb5e46b
d5ce6d5
7efaac1
f508c57
df526d8
577d0d4
50c04dd
baff742
7821962
f358403
24a541c
eb18ec1
c59e3d5
eedd1ee
36f8bf9
dd96898
8418494
6a41212
b49018d
e42c29b
bf33e0d
412f283
ed398c1
4ba9e7a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
template.[yaml|yml|json]
really the default value? or a symbol representing that it will look up these three files in certain order?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, yes. I thought it weird, but that's how the default value is stored in the command, I assume so it's more readable under the CLI as options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will it be always an array of Strings ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. From looking through the parameters, it seems like all parameters that can be lists (only
notification_arns
andcapabilities
) have their items as strings.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will not block the PR on this, but we should think on a away to make it generic, as in future we can add new parameters that accept an array of different types than Strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, will look into investigating click a little more to see if we can pull those data types dynamically 👍