-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove the CDK SAM CLI integration testing and depend on the same test cases defined in CDK repo #5410
Merged
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d9e1cf5
chore: fix CDK Appveyor job and deprecate testing CDK V1
moelasmar d6fcf5a
move CDK testing to GH Actions
moelasmar 154717a
fix spelling mistake
moelasmar dee92d2
run only on aws-sam-cli repo
moelasmar 46e54b8
delete Appveyor Iac integration job
moelasmar 11ff37a
change cron schedule
moelasmar 1a1d9a6
update lambda functions to only use py3.9
moelasmar cd2a6bf
test on my github repo
moelasmar 3a8fc3a
run the GH action only on aws-sam-cli repo
moelasmar 38caa07
update lambda functions to only use py3.9
moelasmar 8fe26b0
test on my github repo
moelasmar 5529b09
run the GH action only on aws-sam-cli repo
moelasmar b5fc0bc
Merge branch 'develop' into develop_CDK_V1_deprecation
moelasmar 6f0197e
chore: remove the CDK SAM CLI integration testing and depend on the s…
moelasmar c574f2f
Merge branch 'develop' into develop_CDK_V1_deprecation
moelasmar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
name: Test the integration between SAM CLI and Latest CDK version | ||
|
||
on: | ||
schedule: | ||
- cron: "0 13 * * 1-5" # run 1PM UTC (6 am PDT) in every weekday | ||
workflow_dispatch: {} | ||
|
||
# to automatically cancel the running workflow for same PR. | ||
concurrency: | ||
group: ${{ github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
integration-tests: | ||
name: Integration Tests / ${{ matrix.python }} | ||
if: github.repository == 'aws/aws-sam-cli' | ||
runs-on: ubuntu-latest | ||
env: | ||
AWS_DEFAULT_REGION: us-east-1 | ||
SAM_CLI_DEV: 1 | ||
NOSE_PARAMETERIZED_NO_WARN: 1 | ||
APPVEYOR_CONSOLE_DISABLE_PTY: false | ||
APPVEYOR_DETAILED_SHELL_LOGGING: true | ||
strategy: | ||
matrix: | ||
python: | ||
- "3.7" | ||
- "3.8" | ||
- "3.11" | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-python@v4 | ||
with: | ||
# set last version as the one in matrix to make it default | ||
python-version: | | ||
3.9 | ||
${{ matrix.python }} | ||
- uses: actions/setup-go@v4 | ||
with: | ||
go-version: '1.19' | ||
- uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: "2.7" | ||
- uses: actions/setup-java@v3 | ||
with: | ||
distribution: 'corretto' | ||
java-version: '8' | ||
- uses: actions/setup-node@v3 | ||
with: | ||
node-version: 14 | ||
- name: Init samdev | ||
run: make init | ||
- name: Run CDK integration tests | ||
run: pytest -vv tests/iac_integration |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
17 changes: 0 additions & 17 deletions
17
tests/iac_integration/cdk/testdata/cdk_v1/java/src/main/java/com/myorg/JavaApp.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why run on a schedule instead of on pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have the CDK integration test cases but we test against the synthesized templates. This integration was created to validate that every new CDK version is generating the template SAM CLI expects it, that is why we originally created the appveyor job to run daily instead of running it with each PR.