feat: Added module output resolving

samcli/hook_packages/terraform/hooks/prepare/resource_linking.py

@@ -99,13 +99,62 @@ def _get_configuration_address(address: str) -> str:
     Cleans all addresses of indices and returns a clean address
 
     Parameters
-    ==========
+    ----------
     address : str
         The address to clean
 
     Returns
-    =======
+    -------
     str
         The address clean of indices
     """
     return re.sub(r"\[[^\[\]]*\]", "", address)
+
+
+def _resolve_module_output(module: TFModule, output_name: str) -> List[Union[ConstantValue, ResolvedReference]]:
+    """
+    Resolves any references in the output section of the module
+
+    Parameters
+    ----------
+    module : Module
+        The module with outputs to search
+    output_name : str
+        The value to resolve
+
+    Returns
+    -------
+    List[Union[ConstantValue, ResolvedReference]]
+        A list of resolved values
+    """
+    results: List[Union[ConstantValue, ResolvedReference]] = []
+
+    output = module.outputs[output_name]
+    output_value = output.value
+
+    if isinstance(output, ConstantValue):
+        results.append(output)
+    elif isinstance(output, References):
+        cleaned_references = _clean_references_list(output_value)
+
+        for reference in cleaned_references:
+            if reference.startswith("var."):
+                stripped_reference = _get_configuration_address(reference[4:])
+                results += _resolve_module_variable(module, stripped_reference)
+            elif reference.startswith("module."):
+                # aaa.bbb.ccc => bbb
+                module_name = reference[7 : reference.rfind(".")]
+                # aaa.bbb.ccc => ccc
+                output_name = reference[reference.rfind(".") + 1 :]
+
+                stripped_reference = _get_configuration_address(module_name)
+
+                results += _resolve_module_output(module.child_modules[stripped_reference], output_name)
+            else:
+                results.append(ResolvedReference(reference, module.full_address or ""))
+
+    return results
+
+
+def _resolve_module_variable(module: TFModule, variable: str):
+    pass

tests/unit/hook_packages/terraform/hooks/prepare/test_resource_linking.py

@@ -1,16 +1,17 @@
 from copy import deepcopy
 from unittest import TestCase
-from unittest.mock import Mock
+from unittest.mock import Mock, patch
 
 from parameterized import parameterized
 
 from samcli.hook_packages.terraform.hooks.prepare.resource_linking import (
     _clean_references_list,
     _get_configuration_address,
+    _resolve_module_output,
     TFModule,
     TFResource,
-    ConstantValue,
     References,
+    ConstantValue,
 )
 
 
@@ -131,3 +132,41 @@ def test_resource_full_address_root_module(self):
         module = TFModule(None, None, {}, {}, {}, {})
         resource = TFResource("resource_address", "type", module, {})
         self.assertEqual(resource.full_address, "resource_address")
+
+    @patch("samcli.hook_packages.terraform.hooks.prepare.resource_linking._resolve_module_variable")
+    @patch("samcli.hook_packages.terraform.hooks.prepare.resource_linking._get_configuration_address")
+    def test_resolve_module_output_with_var(self, config_mock, resolve_var_mock):
+        module = TFModule("", None, {"mycoolref": "mycoolvar"}, [], {}, {"mycooloutput": References(["var.mycoolref"])})
+
+        config_mock.return_value = "mycoolref"
+
+        _resolve_module_output(module, "mycooloutput")
+
+        config_mock.assert_called_with("mycoolref")
+        resolve_var_mock.assert_called_with(module, "mycoolref")
+
+    @patch("samcli.hook_packages.terraform.hooks.prepare.resource_linking._get_configuration_address")
+    def test_resolve_module_output_with_module(self, config_mock):
+        module = TFModule("", None, {}, [], {}, {"mycooloutput": References(["module.mycoolmod"])})
+        module2 = TFModule("module.mycoolmod", module, {}, [], {}, {"mycoolmod": ConstantValue("mycoolconst")})
+        module.child_modules.update({"mycoolmod": module2})
+
+        config_mock.return_value = "mycoolmod"
+
+        results = _resolve_module_output(module, "mycooloutput")
+
+        self.assertEqual(len(results), 1)
+        self.assertEqual(results[0].value, "mycoolconst")
+
+    @parameterized.expand(
+        [
+            (TFModule("", None, {}, [], {}, {"mycooloutput": ConstantValue("mycoolconst")}),),
+            (TFModule("", None, {}, [], {}, {"mycooloutput": References(["mycoolconst"])}),),
+        ]
+    )
+    @patch("samcli.hook_packages.terraform.hooks.prepare.resource_linking._get_configuration_address")
+    def test_resolve_module_output_already_resolved(self, module, config_mock):
+        results = _resolve_module_output(module, "mycooloutput")
+
+        self.assertEqual(len(results), 1)
+        self.assertEqual(results[0].value, "mycoolconst")