Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KeyError caused by not loading assets #3496

Conversation

pseudo-su
Copy link

@pseudo-su pseudo-su commented Nov 25, 2021

Which issue(s) does this change fix?

I think this fixes the following issues

#2968

#2849

Why is this change necessary?

The current _extract_assets method doesn't seem to load the assets correctly, resulting in KeyError's later down the line when trying to extract the stack from the cloud assembly

How does it address the issue?

Reads assets from the manifest successfully when it's in this format

Screen Shot 2021-11-26 at 10 57 34 am

What side effects does this change have?

I have no idea

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pseudo-su pseudo-su marked this pull request as ready for review November 25, 2021 23:49
@jfuss
Copy link
Contributor

jfuss commented Nov 29, 2021

@pseudo-su Thanks for the contribution, however this isn't something we can accept at this time. We are working in parts of the CDK beta into develop and have taking a little bit of a different direction. We are working through these issues still (#3492 works through some of the current gaps we have in the existing implementation that is released).

You can follow https://docs.aws.amazon.com/cdk/latest/guide/sam.html for how this currently works with the stable releases of SAM.
The short version is:

cdk synth --no-staging > template.yaml
sam local invoke MyFunction12345678 --no-event

Replace MyFunction12345678 which your function logical Id.

If there are things you think the beta does well that the above experience doesn't, please open an issue. We are always looking for targeted feedback to make the cli better, especially as we look to expand support for different IAC: #3154

@jfuss jfuss closed this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants