Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integ-tests] Improve integration tests #6639

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

hanwen-cluster
Copy link
Contributor

See commits descriptions for details

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Hanwen <hanwenli@amazon.com>
Similar change to aws#6508

Signed-off-by: Hanwen <hanwenli@amazon.com>
The check was asserting job completion even after Slurm configuration changed to use small memory. I don't see any documentation that guarantees incompatible running jobs still succeed

Signed-off-by: Hanwen <hanwenli@amazon.com>
@hanwen-cluster hanwen-cluster requested review from a team as code owners January 10, 2025 20:28
@hanwen-cluster hanwen-cluster added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Jan 10, 2025
@hanwen-cluster hanwen-cluster enabled auto-merge (rebase) January 10, 2025 20:40
@hanwen-cluster hanwen-cluster merged commit 919f862 into aws:develop Jan 10, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants