[integ-tests] improve build-image integration tests #6627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: This increases test coverage of dependencies files in S3 buckets How 1. Use GPU instances and use availability zones with best GPU capacity 2. Change build-image config file Signed-off-by: Hanwen <hanwenli@amazon.com>
This reverts changes from aws#6450. Because first stage AMIs are not available in China and GovCloud. Some OSes require first stage AMIs Signed-off-by: Hanwen <hanwenli@amazon.com>
Signed-off-by: Hanwen <hanwenli@amazon.com>
Signed-off-by: Hanwen <hanwenli@amazon.com>
Signed-off-by: Hanwen <hanwenli@amazon.com>
Signed-off-by: Hanwen <hanwenli@amazon.com>
c4c5094 to
3bd0d7e
Compare
| @@ -52,8 +52,8 @@ | |||
| "rocky8": {"name": "Rocky-8-EC2-Base-8.8*", "owners": ["792107900819"]}, # TODO add china and govcloud accounts | |||
| "rhel8.9": {"name": "RHEL-8.9*_HVM-*", "owners": RHEL_OWNERS}, | |||
| "rocky8.9": {"name": "Rocky-8-EC2-Base-8.9*", "owners": ["792107900819"]}, # TODO add china and govcloud accounts | |||
| "rhel9": {"name": "RHEL-9.3*_HVM-*", "owners": RHEL_OWNERS}, | |||
| "rocky9": {"name": "Rocky-9-EC2-Base-9.3*", "owners": ["792107900819"]}, # TODO add china and govcloud accounts | |||
| "rhel9": {"name": "RHEL-9.*_HVM*", "owners": RHEL_OWNERS}, | |||
There was a problem hiding this comment.
should we be pinning to 9.4 until fsx lustre supports 9.5?
There was a problem hiding this comment.
This test has Lustre installation disabled for RHEL/Rocky. So we can go head
There was a problem hiding this comment.
I'm not sure if this is what we want. We aren't going to release for an image that doesn't support lustre, so whats the point of testing it? I think we should enable lustre and stick with supported OSes
| Enabled: false | ||
| {% endif %} | ||
| # Disable Lustre installation because these newer operating systems release new kernels more often. Lustre usually does not support the latest kernels | ||
| Enabled: {% if os in ["ubuntu2204", "rhel9", "rocky9"] %} false {% else %} true {% endif %} |
There was a problem hiding this comment.
i wonder if we even care about 9.5 until this is supported.
There was a problem hiding this comment.
I agree. Anyway it is good to make the tests more robust
There was a problem hiding this comment.
lustre should just always be enabled i think
There was a problem hiding this comment.
Done, added another commit
…y9/Ubuntu22 AMIs are used first stage AMIs are used in release.yaml non-first-stage AMIs are used in develop.yaml Signed-off-by: Hanwen <hanwenli@amazon.com>
9a8811f to
62c3b2d
Compare
dreambeyondorange
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
release-3.12branch.Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.