Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥑🤖 v1.14.1 release prep #565

Merged
merged 1 commit into from
Jan 31, 2022
Merged

🥑🤖 v1.14.1 release prep #565

merged 1 commit into from
Jan 31, 2022

Conversation

snay2
Copy link
Contributor

@snay2 snay2 commented Jan 31, 2022

🥑🤖 Auto-generated PR for v1.14.1 release. Updating release versions in repo.

@snay2 snay2 requested a review from a team as a code owner January 31, 2022 21:13
@snay2 snay2 added release-prep PRs opened for release preparation (i.e. release version updates in repo) 🤖 auto-generated🤖 Auto-generated PRs labels Jan 31, 2022
brycahta
brycahta approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@snay2 snay2 mentioned this pull request Jan 31, 2022
Closed
@snay2 snay2 merged commit 8b21d0d into aws:main Jan 31, 2022
@snay2 snay2 deleted the pr/v1.14.1-release branch January 31, 2022 21:50
@stevehipwell
Copy link
Contributor

@brycahta @snay2 @bwagner5 as #540 contained breaking changes shouldn't the chart version have been updated to 0.17.0? I know that technically any change to a SemVer 2 v0.x.y version is a breaking change but it's clearer if the minor version is changed.

@snay2
Copy link
Contributor Author

snay2 commented Feb 1, 2022

@stevehipwell Thanks for bringing that to our attention. In hindsight, I should have made this a minor version release (0.17.0) instead of a patch release because there were technically breaking changes. But after reviewing it with the team this morning, we feel comfortable leaving the helm chart at 0.16.1 despite those changes.

@snay2
Copy link
Contributor Author

snay2 commented Feb 1, 2022 •
edited
Loading

On second thoughts, since the chart hasn't been released to eks-charts yet (aws/eks-charts#675), we're going to take this opportunity to match the version numbers between the chart and the app, and we won't release a chart on version 0.16.1.

Instead, the breaking changes for the helm chart refactor will be in the chart version 1.14.1 to match the NTH app version. PR here: #569

@stevehipwell
Copy link
Contributor

I'd advise against trying to match the chart and app versions, how about chart v1.0.0?

@snay2 snay2 mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycahta brycahta brycahta approved these changes

Assignees
No one assigned
Labels
🤖 auto-generated🤖 Auto-generated PRs release-prep PRs opened for release preparation (i.e. release version updates in repo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snay2 @stevehipwell @brycahta @ec2-bot