Optimize logs #356
Draft
Optimize logs #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was about to submit an issue regarding the excessive logging verbosity caused by this component, but I'm glad to see that logging optimizations are already in progress. The code at https://github.com/aws/aws-network-policy-agent/blob/main/controllers/policyendpoints_controller.go#L327-L333 is generating a high volume of logs in our environments. Could these log statements also be optimized (e.g., moved to debug level) as part of this pull request? |
| @@ -149,7 +149,7 @@ func NewBpfClient(policyEndpointeBPFContext *sync.Map, nodeIP string, enablePoli | |||
| err = ebpfClient.bpfSDKClient.IncreaseRlimit() | |||
| if err != nil { | |||
| //No need to error out from here. We should be good to proceed. | |||
| ebpfClient.logger.Info("Failed to increase RLIMIT on the node....but moving forward") | |||
| ebpfClient.logger.V(1).Info("Failed to increase RLIMIT on the node....but moving forward") | |||
There was a problem hiding this comment.
@dshehbaj Lets wrap this as logger.Debug logger.Info and logger.Error for readability.
We can modify the informational logs to Debug logs and any logs in critical code path should be left as Info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.