Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing LogStreamName #244

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Releasing LogStreamName #244

merged 8 commits into from
Apr 9, 2024

Conversation

ashovlin
Copy link
Member

@ashovlin ashovlin commented Apr 9, 2024

Issue #, if available: N/A

Description of changes: Releasing #242

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashovlin ashovlin requested a review from philasmar April 9, 2024 18:47
@ashovlin ashovlin merged commit 0dd5835 into master Apr 9, 2024
@michaeldimoudis
Copy link
Contributor

Hi @ashovlin and @philasmar I'm wondering whether there is some technical limitation, or if it was an oversight that a new LogStreamName is required each time the app is started/logger created?

When using LogStreamName, the library will only work if the LogStreamName is not already created. However once the LogStreamName is already created, ie: when the app starts up again, no logs will be ingested due to the error Amazon.CloudWatchLogs.Model.ResourceAlreadyExistsException: The specified log stream already exists ---> Amazon.Runtime.Internal.HttpErrorResponseException: The remote server returned an error: (400) Bad Request.

I can help with a PR for this, but I wanted to touch base first.

Log stream creation is at https://github.com/aws/aws-logging-dotnet/blob/master/src/AWS.Logger.Core/Core/AWSLoggerCore.cs#L450-458

@normj
Copy link
Member

normj commented May 13, 2024

@michaeldimoudis This was an oversight. Your PR looks good and I'll make sure we get it released quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants