-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a broader set of compile flags. #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make this PR as a draft. CI detects more warnings reported by the build flags due to gcc8x and aarch. |
torben-hansen
approved these changes
May 19, 2021
dkostic
approved these changes
May 19, 2021
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Mar 9, 2022
torben-hansen
pushed a commit
that referenced
this pull request
Nov 8, 2024
silence -Werror,-Wcast-function-type-mismatch in crypto/rand_extra/windows.c. extend -Wno-cast-function-type to clang versions supporting it. Should address https://gitlab.gnome.org/GNOME/gnome-terminal/-/issues/96 also for clang builds. Ref: Add a broader set of compile flags. #155
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves CryptoAlg-626
Description of changes:
This PR added a broader set of compile flags in
./CMakeLists.txt
.Some compiler warnings are fixed in this PR:
fiat
. The warning is suppressed by__extension__
.-Wpedantic
. #152 (comment)Call-outs:
-Wpedantic
is not enabled to avoid c99 warnings.CryptoAlg-626?selectedConversation=763115b6-a861-42f9-9fa5-acea8cbcb825
.-Wno-unused-parameter
is added instead of usingOPENSSL_UNUSED
because-Wcast-qual
is not enabled because it causes lots of false positive.const ptr
is cast toptr
on macroBORINGSSL_DEFINE_STACK_OF_IMPL
.const ptr
forconstptrtype
.-Wno-cast-function-type
is added when the compiler is gcc8.Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.