Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid appending empty path to artifact directory. #644

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

jdm
Copy link
Contributor

@jdm jdm commented Dec 29, 2024

Issues:

Related to #571 (comment)

The build script for aws-lc-sys appends a library search path to the final linker command line. On Windows environments when building with lld-link.exe, the inclusion of an empty directory at the end of this path can cause a build failure.

The problematic path looks like this: /LIBPATH:C:\\\\a\\\\servo\\\\servo\\\\target\\release\\build\\aws-lc-sys-d847be10163c7448\\out\\build\\artifacts\\

The presence of the \\ at the end of the path causes the subsequent character to be treated as an escaped character, leading to a failure to parse the linker argument that follows this.

Description of changes:

Since the final component of the path is always empty, we can remove it without any behaviour change.

Testing:

Verified this change by building Servo on Windows with my branch of aws-lc-sys. Before the change it failed to build; after the change it builds successfully.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth
Copy link
Contributor

Thanks for the PR! 🚀

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (c358484) to head (423ec30).
Report is 140 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
- Coverage   95.80%   92.89%   -2.91%     
==========================================
  Files          61       67       +6     
  Lines        8143     9717    +1574     
  Branches        0     9717    +9717     
==========================================
+ Hits         7801     9027    +1226     
- Misses        342      402      +60     
- Partials        0      288     +288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth requested a review from skmcgrail December 30, 2024 14:10
@skmcgrail skmcgrail merged commit 990f37a into aws:main Dec 30, 2024
259 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants