Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix errors in the test tool pipeline #1936

Merged
merged 2 commits into from
Jan 25, 2025
Merged

chore: fix errors in the test tool pipeline #1936

merged 2 commits into from
Jan 25, 2025

Conversation

philasmar
Copy link
Contributor

@philasmar philasmar commented Jan 22, 2025 •
edited
Loading

Issue #, if available:
DOTNET-7912
DOTNET-7883

Description of changes:

  • Remove the project dependency between Unit and Integ test projects which was causing issues related to the Test Runner.
  • Added a Common project that has common classes and that project depends on the Test Tool. The unit and integ test projects take a dependency on the Common project.
  • Added a version 0.0.1-beta.1 to prepare for a beta release
  • Fixed an issue where Static Assets were not properly included in the packaged NuGet package
  • Added AutoVer support for the test tool

Note: I have ran these changes in the pipeline and the tests pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@philasmar philasmar requested review from normj and a user January 22, 2025 14:52
@ghost
Copy link

ghost commented Jan 22, 2025

can you confirm all of the integration tests and unit tests still pass after the refactor?

@philasmar philasmar force-pushed the asmarp/fix-testtool-pipeline branch from 4fa7a1c to c2c158a Compare January 22, 2025 15:52
@philasmar
Copy link
Contributor Author

can you confirm all of the integration tests and unit tests still pass after the refactor?

Yes the tests pass in the pipeline.

@philasmar philasmar requested a review from a user January 22, 2025 18:58
@philasmar philasmar force-pushed the asmarp/fix-testtool-pipeline branch from c2c158a to 7a0e5e5 Compare January 23, 2025 14:12
@philasmar philasmar added the Release Not Needed Add this label if a PR does not need to be released. label Jan 23, 2025
@philasmar philasmar force-pushed the asmarp/fix-testtool-pipeline branch from 7a0e5e5 to ff92aab Compare January 23, 2025 15:39
normj
normj requested changes Jan 23, 2025
View reviewed changes
Tools/LambdaTestTool-v2/src/Amazon.Lambda.TestTool/Amazon.Lambda.TestTool.csproj Outdated
@@ -12,8 +12,14 @@
<IsPackable>true</IsPackable>
<PackAsTool>true</PackAsTool>
<PackageId>Amazon.Lambda.TestTool</PackageId>
<ToolCommandName>lambda-test-tool</ToolCommandName>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be dotnet-lambda-test-tool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it

@philasmar philasmar requested a review from normj January 24, 2025 15:22
@philasmar philasmar force-pushed the asmarp/fix-testtool-pipeline branch from 5e92ad4 to 2a6d750 Compare January 24, 2025 15:28
@normj normj merged commit 694d028 into feature/lambdatesttool-v2 Jan 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normj normj normj approved these changes

Assignees
No one assigned
Labels
Release Not Needed Add this label if a PR does not need to be released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philasmar @normj