Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate your code from V1 to V2 Sdk #556

Merged
merged 13 commits into from
Feb 26, 2024
Merged

Migrate your code from V1 to V2 Sdk #556

merged 13 commits into from
Feb 26, 2024

Conversation

alfred2g
Copy link
Contributor

@alfred2g alfred2g commented Feb 2, 2024

Help customers migrate their code from v1 of the sdk to v2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alfred2g alfred2g changed the title Migratie your code from V1 to V2 Sdk Migrate your code from V1 to V2 Sdk Feb 2, 2024
@alfred2g alfred2g requested a review from sfod February 23, 2024 00:31
@alfred2g alfred2g requested a review from sfod February 26, 2024 17:52

The v1 SDK uses `AWSIoTPythonSDK.core` custom logger logger for logging.

The v2 SDK uses a standard [logging facility](https://docs.python.org/3/howto/logging.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is the v2 sdk uses the logger provided by crt, not the standard one.

@alfred2g alfred2g merged commit 9ae575b into main Feb 26, 2024
7 checks passed
@alfred2g alfred2g deleted the migration_guide branch February 26, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants