Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove install instructions from README #1850

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Remove install instructions from README #1850

merged 1 commit into from
Feb 6, 2023

Conversation

archigup
Copy link
Member

@archigup archigup commented Feb 6, 2023

Installation isn't the recommended usage, and causes customer confusion.

Installation isn't the recommended usage, and causes customer confusion.
@archigup archigup requested a review from a team as a code owner February 6, 2023 22:18
Copy link
Member

@AniruddhaKanhere AniruddhaKanhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the below comment/question.
If this is not the recommended method but is still a valid method, then why are we completely removing it? Maybe we should move it to 'Other instructions' section?

@archigup
Copy link
Member Author

archigup commented Feb 6, 2023

We do not recommend customers use CSDK in this way. CSDK is designed around compile time configuration and building it into your application. Having these instructions misleads customers; we often get customers confused trying to use it when it doesn't fit their use case. We also plan to remove this target.

@archigup archigup merged commit 929a86d into main Feb 6, 2023
@archigup archigup deleted the archigup-patch-1 branch February 6, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants