Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid web link for enhanced-custom-auth-using.html #1546

Closed
vikivivi opened this issue Feb 18, 2021 · 5 comments
Closed

Invalid web link for enhanced-custom-auth-using.html #1546

vikivivi opened this issue Feb 18, 2021 · 5 comments

Comments

@vikivivi
Copy link

In the main branch, the following web link found in demo source code is no longer valid.
https://docs.aws.amazon.com/iot/latest/developerguide/enhanced-custom-auth-using.html

Is this the correct link?
https://docs.aws.amazon.com/iot/latest/developerguide/custom-auth.html

grep -rn -B3 "enhanced-custom-auth-using\.html" ./demos/
./demos/mqtt/mqtt_demo_mutual_auth/mqtt_demo_mutual_auth.c-596-         * For username and password based authentication in AWS IoT,
./demos/mqtt/mqtt_demo_mutual_auth/mqtt_demo_mutual_auth.c-597-         * #AWS_IOT_PASSWORD_ALPN is used. More details can be found in the
./demos/mqtt/mqtt_demo_mutual_auth/mqtt_demo_mutual_auth.c-598-         * link below.
./demos/mqtt/mqtt_demo_mutual_auth/mqtt_demo_mutual_auth.c:599:         * https://docs.aws.amazon.com/iot/latest/developerguide/enhanced-custom-auth-using.html
--
./demos/ota/ota_demo_core_mqtt/ota_demo_core_mqtt.c-944-         * For username and password based authentication in AWS IoT,
./demos/ota/ota_demo_core_mqtt/ota_demo_core_mqtt.c-945-         * #AWS_IOT_PASSWORD_ALPN is used. More details can be found in the
./demos/ota/ota_demo_core_mqtt/ota_demo_core_mqtt.c-946-         * link below.
./demos/ota/ota_demo_core_mqtt/ota_demo_core_mqtt.c:947:         * https://docs.aws.amazon.com/iot/latest/developerguide/enhanced-custom-auth-using.html
--
./demos/ota/ota_demo_core_http/ota_demo_core_http.c-1070-         * For username and password based authentication in AWS IoT,
./demos/ota/ota_demo_core_http/ota_demo_core_http.c-1071-         * #AWS_IOT_PASSWORD_ALPN is used. More details can be found in the
./demos/ota/ota_demo_core_http/ota_demo_core_http.c-1072-         * link below.
./demos/ota/ota_demo_core_http/ota_demo_core_http.c:1073:         * https://docs.aws.amazon.com/iot/latest/developerguide/enhanced-custom-auth-using.html
@abhidixi11
Copy link
Contributor

Hello @vikivivi ,
Thanks for pointing it out.
https://docs.aws.amazon.com/iot/latest/developerguide/custom-auth.html
Looks like the correct link to me. We will update it soon.
Thanks!

@vikivivi
Copy link
Author

vikivivi commented Feb 18, 2021

Hello @abhidixi11 ,
Beside the above link, you might also want to check the following link as well.
https://docs.aws.amazon.com/iot/latest/developerguide/enhanced-custom-authentication.html

grep -rn "enhanced-custom-authentication" demos/

Also this link in docs directory.
https://docs.aws.amazon.com/iot/latest/developerguide/iot-console-signin.html

I guess the new link for iot-console-signin should be
https://docs.aws.amazon.com/iot/latest/developerguide/setting-up.html

grep -rn "iot-console-signin" ./docs/

leegeth added a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this issue Feb 23, 2021
gkwicker pushed a commit that referenced this issue Feb 24, 2021
* Update broken links in demo comments and documentation.

This is to fix the Github issue #1546

* Fix spell checks

* Address review comments
@leegeth
Copy link
Contributor

leegeth commented Feb 24, 2021

@vikivivi,

Thank you bringing this issue to our attention. We have merged a PR #1552 to address the issues you brought up. Please let us know if you have any further questions or concerns.

@vikivivi
Copy link
Author

Sorry @leegeth , this link in demos is still broken. The other 2 broken links are fixed. Thank you.
https://docs.aws.amazon.com/iot/latest/developerguide/enhanced-custom-auth-using.html

grep -rn -B3 "enhanced-custom-auth-using\.html" demos/

@vikivivi
Copy link
Author

Thank you @leegeth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants