Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Python3.7 support #648

Merged
merged 8 commits into from
May 15, 2024
Merged

Conversation

texastony
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Stop testing or advertising support for py3.7
  • Tell PyPi we support 3.10, 3.11, 3.12

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@texastony texastony requested a review from a team as a code owner March 2, 2024 01:09
@texastony texastony changed the title chore: remove py3.7 testing feat: remove Python3.7 support Mar 2, 2024
@texastony
Copy link
Contributor Author

On Approval, we should remove Python3.7 from required Checks.

Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there's some other spots in the tests we should clean up as well, but those aren't as important.
Question: Can we also remove appveyor.yml as part of this change?

@texastony
Copy link
Contributor Author

Looks good, there's some other spots in the tests we should clean up as well, but those aren't as important. Question: Can we also remove appveyor.yml as part of this change?

All these asks are reasonable.
I am not going to work on them right now, as I need to focus on my sprint work.
But the On Call or anyone can push to this branch to address these.

@ShubhamChaturvedi7
Copy link
Contributor

Looks good, there's some other spots in the tests we should clean up as well, but those aren't as important. Question: Can we also remove appveyor.yml as part of this change?

Already removed here: e28d146

@ShubhamChaturvedi7 ShubhamChaturvedi7 enabled auto-merge (squash) May 15, 2024 21:59
@ShubhamChaturvedi7 ShubhamChaturvedi7 merged commit 2dbd62b into master May 15, 2024
155 checks passed
@ShubhamChaturvedi7 ShubhamChaturvedi7 deleted the tony/chore-py310-gt branch May 15, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants