-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the brand new 3.13 release of pyyaml #3430
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3430 +/- ##
===========================================
+ Coverage 94.4% 94.41% +<.01%
===========================================
Files 169 169
Lines 13252 13252
===========================================
+ Hits 12511 12512 +1
+ Misses 741 740 -1
Continue to review full report at Codecov.
|
Any status on this? Currently our CI/CD is blocked on it without downgrading our image to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this works fine, no travis entry for it yet though.
@stealthycoin I can add that in a separate PR or in this one -- imo orthogonal to allowing new pyyaml though :) |
For the impatient:
|
fwiw, there's a single failure in python3.7:
|
@asottile Yep I see that now too. I ran in 3.6 on accident. So that needs to get figured out before this can be merged. Edit: I guess that would be a blocking issue on adding the 3.7 travis entries not really this PR. |
@stealthycoin why does that block this? pyyaml 3.13 works fine for the other supported python versions today |
@asottile It isn't. I am currently running the branch through it through integration tests. |
@stealthycoin any updates on this? not sure why this is taking so long -- 3.13 is the same codebase as 3.12 it's just a version bump from the pyyaml side |
How about EB CLI? Is that changed to use pyyaml 3.13 when installed with pip? Cause I am still getting an error when using a docker python image on circleci with python 3.7.0. |
`awscli` version we used to pin depends on `pyyaml` that doesn't support py37 The issue got fixed in aws/aws-cli#3430 `botocore` is also updated as `awscli` and `botocore` should usually be synchronized.
`awscli` version we used to pin depends on `pyyaml` that doesn't support py37 The issue got fixed in aws/aws-cli#3430 `botocore` is also updated as `awscli` and `botocore` should usually be synchronized.
`awscli` version we used to pin depends on `pyyaml` that doesn't support py37 The issue got fixed in aws/aws-cli#3430 `botocore` is also updated as `awscli` and `botocore` should usually be synchronized.
reapply of #3414 but for just-released 3.13 instead
This enables awscli to be installable on python3.7
Note that 3.13 is essentially a re-release of 3.12 but with a newly cythonized _yaml.c file