-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an export primitive to use with eval to simplify exporting variables #2454
Conversation
Any chances to have some feedback on this feature ? |
Personally I'm a little uncomfortable with this feature, largely because the question of how to export environment variables is going to be very shell dependent, for example this is going to fail with the Perhaps the others might have a different opinion though. |
Agreed that it is largely shell depend, i'm open to any changes to make it less shell dependent, I'm just looking into |
Do you have any updates on this ? Regards |
I did create a yaws project on pip to allow my users to use the export, is there any chance to have this PR merge ? |
@stealthycoin or @dstufft should I remove the pull request or is there any chances it makes it to the project? Thank you |
Hi @loopingz, Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. We are working through open PRs and are trying to determine where this feature request falls. For feature requests, to invest the time in reviewing it, we would like to make sure the feature has wider community interest and are looking for 10 👍 votes on the linked issue. For the currently open PR, we are going to set it as a draft. Once the 👍 threshold is met, we will move it to the “Contribution Ready” state. |
@justindho this PR for example got so many +1 for no result: #2710 and was just closed as is. For this issue, I created this repository https://github.com/loopingz/yaws/stargazers Also, I'd like to mention that we are talking about PR that were created in 2017... I'm glad to have someone finally working on it. |
Checking in - thanks for your patience and for creating this PR. I think this had fallen off of the team's radar but it looks like the feature has now been implemented via #7398. I hope that addresses your use case. For feature requests related to this command you can create a new issue for further review. Please let us know if you had any follow up questions or feedback. |
Issue #, if available:
#6962
As some of the tools i use need the environment variable to be set, switching from one profile to another was painfull, by adding this method i can just run
eval
aws configure export --profile myprofile
Going back to the default with
eval
aws configure export
I would have prefered to export the variables from Python directly but it looks like it is not possible