Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an export primitive to use with eval to simplify exporting variables #2454

Closed
wants to merge 1 commit into from

Conversation

loopingz
Copy link

@loopingz loopingz commented Feb 19, 2017

Issue #, if available:
#6962

As some of the tools i use need the environment variable to be set, switching from one profile to another was painfull, by adding this method i can just run

eval aws configure export --profile myprofile

Going back to the default with

eval aws configure export

I would have prefered to export the variables from Python directly but it looks like it is not possible

@loopingz
Copy link
Author

loopingz commented Mar 4, 2017

Any chances to have some feedback on this feature ?

@dstufft
Copy link
Contributor

dstufft commented Mar 20, 2017

Personally I'm a little uncomfortable with this feature, largely because the question of how to export environment variables is going to be very shell dependent, for example this is going to fail with the fish shell.

Perhaps the others might have a different opinion though.

@loopingz
Copy link
Author

Agreed that it is largely shell depend, i'm open to any changes to make it less shell dependent, I'm just looking into fish to see if i can find something. I'm using my modified version of aws cli on daily basis and it was really usefull for me to switch from one aws account to another

@loopingz
Copy link
Author

Do you have any updates on this ?

Regards

@loopingz
Copy link
Author

I did create a yaws project on pip to allow my users to use the export, is there any chance to have this PR merge ?

@loopingz
Copy link
Author

loopingz commented May 9, 2018

@stealthycoin or @dstufft should I remove the pull request or is there any chances it makes it to the project? Thank you

@justindho
Copy link
Contributor

Hi @loopingz,

Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. We are working through open PRs and are trying to determine where this feature request falls.

For feature requests, to invest the time in reviewing it, we would like to make sure the feature has wider community interest and are looking for 10 👍 votes on the linked issue. For the currently open PR, we are going to set it as a draft. Once the 👍 threshold is met, we will move it to the “Contribution Ready” state.

@justindho justindho marked this pull request as draft May 17, 2022 18:16
@loopingz
Copy link
Author

@justindho this PR for example got so many +1 for no result: #2710 and was just closed as is.

For this issue, I created this repository https://github.com/loopingz/yaws/stargazers
It has some stars from the community, pip does not keep track of number of downloads.

Also, I'd like to mention that we are talking about PR that were created in 2017... I'm glad to have someone finally working on it.

@tim-finnigan
Copy link
Contributor

Checking in - thanks for your patience and for creating this PR. I think this had fallen off of the team's radar but it looks like the feature has now been implemented via #7398.

I hope that addresses your use case. For feature requests related to this command you can create a new issue for further review. Please let us know if you had any follow up questions or feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an export primitive to use with eval to simplify exporting variables
6 participants