fix(lambda-nodejs): permission denied on npm cache #9167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The npm cache was owned by the user 1000 so if the image was run by a user other than 1000 installing via npm resulted in a `EACCES` error on the cache folder. Yarn automatically falls back to `/tmp` in this case. Move npm cache folder creation to the end of the Dockerfile so that no root content has been created in it when the image starts. Set cache folder permission to 777. Also disable npm update notification and add tests for the Dockerfile.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Jul 20, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Chriscbr
pushed a commit
to Chriscbr/aws-cdk
that referenced
this pull request
Jul 23, 2020
The npm cache was owned by the user 1000 so if the image was run by a user other than 1000 installing via npm (when using the `nodeModules` prop) resulted in a `EACCES` error on the cache folder. Yarn automatically falls back to `/tmp` in this case. Move npm cache folder creation to the end of the Dockerfile so that no root content has been created in it when the image starts. Set cache folder permission to 777. Also disable npm update notification and add tests for the Dockerfile. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
The npm cache was owned by the user 1000 so if the image was run by a user other than 1000 installing via npm (when using the `nodeModules` prop) resulted in a `EACCES` error on the cache folder. Yarn automatically falls back to `/tmp` in this case. Move npm cache folder creation to the end of the Dockerfile so that no root content has been created in it when the image starts. Set cache folder permission to 777. Also disable npm update notification and add tests for the Dockerfile. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The npm cache was owned by the user 1000 so if the image was run by
a user other than 1000 installing via npm (when using the
nodeModulesprop) resulted in a
EACCESerror on the cache folder. Yarn automaticallyfalls back to
/tmpin this case.Move npm cache folder creation to the end of the Dockerfile so that no
root content has been created in it when the image starts. Set cache
folder permission to 777.
Also disable npm update notification and add tests for the Dockerfile.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license