-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): weak references #8891
Closed
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import { CfnResource } from '../cfn-resource'; | ||
import { Construct } from '../construct-compat'; | ||
|
||
export interface SsmStringParameterProps { | ||
/** | ||
* Name of the ssm string parameter. Should be unique for the AWS account. | ||
*/ | ||
readonly name: string; | ||
/** | ||
* The value stored in SSM | ||
*/ | ||
readonly value: string; | ||
/** | ||
* Optional description | ||
*/ | ||
readonly description?: string; | ||
} | ||
|
||
export class SsmStringParameter extends Construct { | ||
constructor(scope: Construct, id: string, props: SsmStringParameterProps) { | ||
super(scope, id); | ||
|
||
new CfnResource(this, id, { | ||
type: 'AWS::SSM::Parameter', | ||
properties: { | ||
Name: props.name, | ||
Description: props.description, | ||
Type: 'String', | ||
Value: props.value, | ||
}, | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import { Test } from 'nodeunit'; | ||
import { Stack } from '../../lib'; | ||
import { SsmStringParameter } from '../../lib/private/ssm-parameter'; | ||
import { toCloudFormation } from '../util'; | ||
|
||
export = { | ||
'ssm string parameter construct is correctly rendered'(test: Test) { | ||
const stack = new Stack(); | ||
new SsmStringParameter(stack, 'string-param', { | ||
name: 'ParamName', | ||
value: 'ParamValue', | ||
description: 'ParamDescription', | ||
}); | ||
|
||
test.deepEqual(toCloudFormation(stack), { | ||
Resources: { | ||
stringparam5E4312EC: { | ||
Type: 'AWS::SSM::Parameter', | ||
Properties: { | ||
Name: 'ParamName', | ||
Description: 'ParamDescription', | ||
Type: 'String', | ||
Value: 'ParamValue', | ||
}, | ||
}, | ||
}, | ||
}); | ||
|
||
test.done(); | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be a tri-state to accomodate existing deployments, and you need to explain people how to migrate from a situation where they are stuck performing an update they are planning to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this is needed actually or there is RoI for the added complexity.
I have only one use case for this. Users have likely worked around when they discovered this gap by keeping the layer and the function in the same stack or some other mechanism. The issue has been open long enough that I don't think anyone is waiting.
Nevertheless, I've asked if anyone is stuck in this state on a production stack.
Throwing this behind a feature flag that's enabled for new projects should be sufficient. Existing users will have to destroy and re-create their stacks to avail this benefit.