Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(scripts): buildup should only build #8782

Merged
merged 2 commits into from
Jun 29, 2020
Merged

chore(scripts): buildup should only build #8782

merged 2 commits into from
Jun 29, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Jun 29, 2020

Skip the test target to speed up building up to the module. This will
significantly improve the speed to arrive to a working module after
check out.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

chore(scripts): buildup should only build
8589fb2 
Skip the test target to speed up building up to the module. This will
significantly improve the speed to arrive to a working module after
check out.
@nija-at nija-at requested a review from a team June 29, 2020 11:22
@nija-at nija-at self-assigned this Jun 29, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 29, 2020
njlynch
njlynch approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about keeping the build+test behavior as an optional flag (e.g., buildup --resume --tests)? I guess that functionality is more important for builddown than buildup, but there still could be good reasons to want to execute all of the upstream tests.

@nija-at
Copy link
Contributor Author

nija-at commented Jun 29, 2020

What do you think about keeping the build+test behavior as an optional flag (e.g., buildup --resume --tests)? I guess that functionality is more important for builddown than buildup, but there still could be good reasons to want to execute all of the upstream tests.

We can directly use the foreach script to execute any combination of build, test, lint and pack. buildup is currently just a simple alias and doesn't feel like it warrants argument parsing and the different options.

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@pahud
Copy link
Contributor

pahud commented Jun 29, 2020

I have been using foreach.sh --up yarn build for a while. Happy to see this PR! Thanks!

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b3855ff into master Jun 29, 2020
@mergify mergify bot deleted the nija-at/buildup-donottest branch June 29, 2020 12:03
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c6a6cca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@hanack
Copy link

hanack commented Jun 29, 2020 via email

@BryanPan342 BryanPan342 mentioned this pull request Jul 1, 2020
Merged
whimzyLive pushed a commit to whimzyLive/aws-cdk that referenced this pull request Jul 1, 2020
@whimzyLive
chore(scripts): buildup should only build (aws#8782)
c2f8fca 
Skip the test target to speed up building up to the module. This will
significantly improve the speed to arrive to a working module after
check out.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlynch njlynch njlynch approved these changes

Assignees

@nija-at nija-at

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nija-at @pahud @aws-cdk-automation @hanack @njlynch