chore: master version in lerna.json (instead of root package.json) #6445
Conversation
Use lerna.json to master the repo version instead of the root package.json. Move standard-version configuration to .versionrc.json and consult it when aligning the repo version to determine where the version is mastered.
returns the current repo version, and reused by align-version. then we can use it in our AutoBump build project instead of hard-coding the fact that lerna.json is where we master the version.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
1 similar comment
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -9,11 +9,11 @@ scriptdir=$(cd $(dirname $0) && pwd) | |||
| # go to repo root | |||
| cd ${scriptdir}/.. | |||
|
|
|||
| files="lerna.json $(find . -name package.json | grep -v node_modules | grep -v "^./package.json" | xargs)" | |||
| files="$(find . -name package.json | grep -v node_modules | xargs)" | |||
There was a problem hiding this comment.
Hmm. I guess I had assumed this would just be a lerna version command if we put the version in lerna.json. Isn't it?
There was a problem hiding this comment.
Lerna version doesn’t take care of peer dependencies and occasionally misses things. This is more straightforward I believe.
| --bumpFiles package.json \ | ||
| --release-as ${version} \ | ||
| --skip.tag=true \ | ||
| --releaseCommitMessageFormat="chore(release): v{{currentTag}}" \ |
There was a problem hiding this comment.
This is not in the .versionrc.json file?
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Personally prefer the command line flags version, but whatever suits you.
There was a problem hiding this comment.
Me too, but I couldn’t find a way to specify the packageFiles type through the command line so I had to revert to this abomination.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Use
lerna.jsonto master the repo version instead of the root package.json.Move standard-version configuration to .versionrc.json and consult it when aligning the repo version to determine where the version is mastered.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license