chore(monocdk): bundle lambda handlers #6096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2020 16:46
Bundle all the rest of the module code into the monocdk bundle. Current size: 14MiB (compressed)
nija-at
approved these changes
Feb 4, 2020
packages/monocdk-experiment/gen.js
Outdated
| @@ -4,6 +4,9 @@ const fs = require('fs-extra'); | |||
| const path = require('path'); | |||
| const glob = require('glob'); | |||
|
|
|||
| const INCLUDE_DIRS = [ 'lib', 'lambda', 'lambda-packages' ]; | |||
| const EXCLUDE_DIRS = [ 'lib', 'test', 'node_modules', 'scripts', 'build-tools', 'rosetta', 'suffixes' ]; | |||
There was a problem hiding this comment.
We don't need lib in both lists, right? Just in the include should be sufficient.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
added 3 commits
February 5, 2020 09:40
in order to ensure that the bundled module is not polluted by the mono-repo and that we actually bundle non-jsii dependencies.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle all the rest of the module code into the monocdk bundle.
Current size: ~30MiB (compressed)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license