Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2-alpha): update default config for Subnet's assignIpv6AddressOnCreation #34116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Leo10Gama
Copy link
Member

@Leo10Gama Leo10Gama commented Apr 11, 2025

Issue # (if applicable)

N/A

Reason for this change

The Subnet.assignIpv6AddressOnCreation attribute was being set in the L1, despite it not being necessary to set. This may cause issues with backwards migrations from V1 subnets to V2, since there will be this attribute difference across both.

Description of changes

const subnet = new CfnSubnet(this, 'Subnet', {
  ...
  assignIpv6AddressOnCreation: props.assignIpv6AddressOnCreation /* ?? false */,
  mapPublicIpOnLaunch: props.mapPublicIpOnLaunch /* ?? undefined */ // this one was just a redundant nit
}

Describe any new or updated permissions being added

N/A

Description of how you validated changes

yarn test && yarn integ-runner --update-on-failed --dry-run (dry run since it's a very minor change, and some of the integ tests for IPv6 and IPAM are finnicky)

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 11, 2025 21:33
@github-actions github-actions bot added the p2 label Apr 11, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 11, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@Leo10Gama Leo10Gama changed the title fix(ec2-alpha): update default config for Subnet's assignIpv6AddressOnCreation chore(ec2-alpha): update default config for Subnet's assignIpv6AddressOnCreation Apr 11, 2025
@Leo10Gama Leo10Gama changed the title chore(ec2-alpha): update default config for Subnet's assignIpv6AddressOnCreation fix(ec2-alpha): update default config for Subnet's assignIpv6AddressOnCreation Apr 11, 2025
@Leo10Gama
Copy link
Member Author

Exemption Request: I updated the snapshots, but the integ tests themselves are fine

@Leo10Gama Leo10Gama added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Apr 11, 2025
@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 11, 2025
@Leo10Gama Leo10Gama removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 11, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 11, 2025 21:42

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (74cbe27) to head (74ed628).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #34116   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112           
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 74ed628
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants