-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ec2-alpha): update default config for Subnet's assignIpv6AddressOnCreation
#34116
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
assignIpv6AddressOnCreation
assignIpv6AddressOnCreation
assignIpv6AddressOnCreation
assignIpv6AddressOnCreation
Exemption Request: I updated the snapshots, but the integ tests themselves are fine |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34116 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 120 120
Lines 6976 6976
Branches 1178 1178
=======================================
Hits 5859 5859
Misses 1005 1005
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
N/A
Reason for this change
The
Subnet.assignIpv6AddressOnCreation
attribute was being set in the L1, despite it not being necessary to set. This may cause issues with backwards migrations from V1 subnets to V2, since there will be this attribute difference across both.Description of changes
Describe any new or updated permissions being added
N/A
Description of how you validated changes
yarn test && yarn integ-runner --update-on-failed --dry-run
(dry run since it's a very minor change, and some of the integ tests for IPv6 and IPAM are finnicky)Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license