Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2-alpha): add multiple NATGW to the VPC using addNatGateway method #34094

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Apr 9, 2025

Closes #.

Reason for this change

Cannot add multiple NATGW to current VPC construct as it is using the same construct id which cause conflict.

Description of changes

  • Fix the NATGW construct id to be unique using provided subnet.
  • Fix the current domain being set in EIP to be vpc instead of vpcId.
  • Fix the validation for subnet IP ranges as those can be unresolved token values referred in VPC construct using vpc.attr. .

Describe any new or updated permissions being added

NA

Description of how you validated changes

  • Added unit test and integration test for NATGW.
  • Added unit test for EIP

Checklist


BREAKING CHANGE : The logical ID for the NAT Gateway, defined using the addNatGateways method, will be changed, resulting in the NAT Gateway being recreated. Additionally, the domain for the Elastic IP (EIP) will be set to vpc, which will also trigger its recreation in the account.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 9, 2025 23:00
@github-actions github-actions bot added the p2 label Apr 9, 2025
@shikha372 shikha372 changed the title feat(eks): pass additional helm chart values to aws-load-balancer-con… fix(ec2-alpha): add multiple NATGW to the VPC using addNatGateway method Apr 9, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 9, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review April 10, 2025 23:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@shikha372
Copy link
Contributor Author

BREAKING CHANGE : The logical ID for the NAT Gateway, defined using the addNatGateways method, will be changed, resulting in the NAT Gateway being recreated. Additionally, the domain for the Elastic IP (EIP) will be set to vpc, which will also trigger its recreation in the account.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Breaking changes should be indicated by starting a line with 'BREAKING CHANGE: ', variations are not allowed. (found: 'BREAKING CHANGE : The logical ID for the NAT Gateway, defined using the `addNatGateways` method, will be changed, resulting in the NAT Gateway being recreated. Additionally, the domain for the Elastic IP (EIP) will be set to `vpc`, which will also trigger its recreation in the account.').

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7c98453
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants