-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ec2-alpha): add multiple NATGW to the VPC using addNatGateway method #34094
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
BREAKING CHANGE : The logical ID for the NAT Gateway, defined using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Breaking changes should be indicated by starting a line with 'BREAKING CHANGE: ', variations are not allowed. (found: 'BREAKING CHANGE : The logical ID for the NAT Gateway, defined using the `addNatGateways` method, will be changed, resulting in the NAT Gateway being recreated. Additionally, the domain for the Elastic IP (EIP) will be set to `vpc`, which will also trigger its recreation in the account.').
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Closes #.
Reason for this change
Cannot add multiple NATGW to current VPC construct as it is using the same construct id which cause conflict.
Description of changes
vpc
instead ofvpcId
.Describe any new or updated permissions being added
NA
Description of how you validated changes
Checklist
BREAKING CHANGE : The logical ID for the NAT Gateway, defined using the
addNatGateways
method, will be changed, resulting in the NAT Gateway being recreated. Additionally, the domain for the Elastic IP (EIP) will be set tovpc
, which will also trigger its recreation in the account.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license