-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neptune-alpha): add engine versions and parameter group family 1.4 #34091
Open
masterhugo
wants to merge
6
commits into
aws:main
Choose a base branch
from
masterhugo:neptune-alpha/33807-add-engine-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(neptune-alpha): add engine versions and parameter group family 1.4 #34091
masterhugo
wants to merge
6
commits into
aws:main
from
masterhugo:neptune-alpha/33807-add-engine-versions
+1,383
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
previously requested changes
Apr 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
…hub.com/masterhugo/aws-cdk into neptune-alpha/33807-add-engine-versions
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
2 tasks
Approved! |
dpjn316gh
approved these changes
Apr 9, 2025
Hinkapie
approved these changes
Apr 9, 2025
apiedrahitav
approved these changes
Apr 9, 2025
chaacxib
approved these changes
Apr 9, 2025
Zekkenn
approved these changes
Apr 9, 2025
WhiteArctic
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beginning-contributor
[Pilot] contributed between 0-2 PRs to the CDK
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #33807
Closes #33807.
Reason for this change
To update engine versions
Description of changes
add engine versionas and family group 1.4 to be updated with this
https://docs.aws.amazon.com/neptune/latest/userguide/engine-releases.html
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Yes, i achange two unit tests and add one integration test to validate family paramter group 1.4
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license