Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): pass additional helm chart values to aws-load-balancer-controller #34077

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Apr 8, 2025

Issue # (if applicable)

Closes #29707 .

Reason for this change

Currently passing in additional value to ALB helm chart is not supported.
Added support for value enableWaf and enableWafv2
List of supported values can be verified from https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/helm/aws-load-balancer-controller/values.yaml#L199

Description of changes

  • Added new interface AlbControllerHelmChartOptions to support additional helm chart values
  • Added support for boolean type value enableWaf and enableWafv2

Describe any new or updated permissions being added

NA

Description of how you validated changes

  • Added Unit test
  • Modified integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 8, 2025 23:43
@github-actions github-actions bot added the p2 label Apr 8, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 8, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Apr 8, 2025
@shikha372 shikha372 force-pushed the shikagg/eks-alb-controller branch from 7b2b36a to 1b8a765 Compare April 9, 2025 21:28
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 9, 2025 21:30

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@shikha372 shikha372 force-pushed the shikagg/eks-alb-controller branch from 4218571 to a014cc3 Compare April 9, 2025 22:03
@shikha372 shikha372 marked this pull request as ready for review April 9, 2025 22:17
@shikha372 shikha372 assigned shikha372 and paulhcsun and unassigned shikha372 Apr 10, 2025
@paulhcsun paulhcsun changed the title feat(eks): pass additional helm chart values to aws-load-balancer-con… feat(eks): pass additional helm chart values to aws-load-balancer-controller Apr 11, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5829cb3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-eks]: add support for passing helm chart values to AlbController
3 participants