chore(cloudwatch): backfill missing enums for cloudwatch #33640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33640 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 119 119
Lines 6876 6876
Branches 1162 1162
=======================================
Hits 5653 5653
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Leo10Gama
reviewed
Mar 1, 2025
paulhcsun
commented
Mar 1, 2025
Comment on lines
158
to
+164
| * A special value for use with search expressions to have the default value be the first value returned from search | ||
| */ | ||
| public static readonly FIRST = new DefaultValue('__FIRST'); | ||
| /** | ||
| * [PLACEHOLDER COMMENT: TO BE FILLED OUT] | ||
| */ | ||
| public static readonly LAST = new DefaultValue('last'); |
There was a problem hiding this comment.
Based on the difference in the actual value __FIRST vs. last, this may be an incorrectly mapped enum. Adding the do-not-merge tag until we can investigate if this is the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
backfill missing enums for cloudwatch
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license