feat(codepipeline-actions): native Amazon EC2 deployment support #33604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tietew
commented
Feb 27, 2025
There was a problem hiding this comment.
contains 3 files:
index.html- fetched on assertionsscripts/pre-deploy.sh- specified aspreScript; just runstruescripts/post-deploy.sh- specified aspostScript; just runstrue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33604 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 119 119
Lines 6876 6876
Branches 1162 1162
=======================================
Hits 5653 5653
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Tietew
commented
Feb 27, 2025
| /** | ||
| * Max number of instances. | ||
| * | ||
| * Valid range: from 1 to number of your instances |
There was a problem hiding this comment.
Validation based on AWS console:
Tietew
commented
Feb 27, 2025
| /** | ||
| * Max percentage of instances. | ||
| * | ||
| * Valid range: from 1 to 99 |
There was a problem hiding this comment.
Validation based on AWS console:
Tietew
commented
Feb 27, 2025
| TargetDirectory: this.props.targetDirectory, | ||
| MaxBatch: this.props.maxBatch?.value, | ||
| MaxError: this.props.maxError?.value, | ||
| TargetGroupNameList: this.props.targetGroups?.length ? this.props.targetGroups.map((tg) => tg.targetGroupName).join(',') : undefined, |
There was a problem hiding this comment.
From AWS console, TargetGroupListName is a comma-separated string instead of a JSON array.
Result of GetPipeline: (pipeline created by console)
Tietew
commented
Feb 27, 2025
| if (!Token.isUnresolved(percentage) && !(percentage >= 1 && percentage <= 99 && Number.isInteger(percentage))) { | ||
| throw new UnscopedValidationError(`percentage must be a positive integer between 1 and 99. got ${percentage}`); | ||
| } | ||
| return { value: `${Tokenization.stringifyNumber(percentage)}%` }; |
There was a problem hiding this comment.
From AWS console, percentage is represented as "NN%"
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Tietew
commented
Feb 27, 2025
Comment on lines
+148
to
+155
| if ( | ||
| props.maxBatch && props.maxError && | ||
| !Token.isUnresolved(props.maxBatch.value) && !Token.isUnresolved(props.maxError.value) && | ||
| props.maxBatch.value.endsWith('%') === props.maxError.value.endsWith('%') && | ||
| parseInt(props.maxBatch.value, 10) <= parseInt(props.maxError.value, 10) | ||
| ) { | ||
| throw new UnscopedValidationError(`The maxError must be less than the maxBatch ${props.maxBatch.value}. got ${props.maxError.value}`); | ||
| } |
There was a problem hiding this comment.
When maxBatch <= maxError, action execution will fail:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #33584.
Reason for this change
AWS CodePipeline introduces a new action to deploy to Amazon Elastic Compute Cloud (EC2).
https://aws.amazon.com/about-aws/whats-new/2025/02/aws-codepipeline-native-ec2-deployment-support/
Description of changes
Added
Ec2DeployActionaction class.Usage:
Describe any new or updated permissions being added
Ec2DeployActionadds permissions based on CodePipeline documentation:https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-EC2Deploy.html#action-reference-EC2Deploy-permissions-action
Description of how you validated changes
Unit tests and an integ test.
The integ test also asserts pipeline execution.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license