Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak enum-like parser to exclude certain classes #33536

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

Leo10Gama
Copy link
Member

@Leo10Gama Leo10Gama commented Feb 20, 2025

Issue # (if applicable)

N/A

Reason for this change

The enum-like parser was pulling in some classes that did not follow the pattern of enum-like classes. This alleviates that by, rather than looking for fields that are strictly not strings, fields that strictly follow the pattern:

  public static readonly NEW_EXPRESSION = new SomeClass(...);
  public static readonly CALL_EXPRESSION = SomeClass.method(...);
  public static readonly ACCESS_EXPRESSION = MyClass.ANOTHER_ENUM;

Description of changes

Altered the parsing logic to be more specific, and reran the script to parse enum-likes.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

yarn test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@Leo10Gama Leo10Gama requested a review from a team as a code owner February 20, 2025 23:55
@aws-cdk-automation aws-cdk-automation requested a review from a team February 20, 2025 23:55
@github-actions github-actions bot added the p2 label Feb 20, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 20, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (315be88) to head (37b6fd6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33536   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files         119      119           
  Lines        6862     6862           
  Branches     1158     1158           
=======================================
  Hits         5639     5639           
  Misses       1120     1120           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Feb 21, 2025

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 37b6fd6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 47cae25 into aws:main Feb 21, 2025
26 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025
@Leo10Gama Leo10Gama deleted the more-enumlike branch February 21, 2025 04:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants